Add RepositoryDiscussion powered by GraphQL API#3048
Merged
EnricoMi merged 20 commits intoPyGithub:mainfrom Oct 29, 2024
Merged
Add RepositoryDiscussion powered by GraphQL API#3048EnricoMi merged 20 commits intoPyGithub:mainfrom
RepositoryDiscussion powered by GraphQL API#3048EnricoMi merged 20 commits intoPyGithub:mainfrom
Conversation
tiangolo
approved these changes
Oct 27, 2024
Contributor
tiangolo
left a comment
There was a problem hiding this comment.
I took the liberty of reviewing this. Looks great! 🚀
I cloned it locally and reviewed it line by line. I first reviewed the previous 2 PRs this depends on.
I have been using it for internal scripts in FastAPI and it's working great.
I have a couple of minor suggestions.
LGTM! 🚀
Disclaimer: I requested this feature to use it in FastAPI.
9becf8b to
8a5789f
Compare
- Make output_schema mendatory in function where retrieval of GraphQl data is main purpose - Remove curly brackets from output_schema parameter
d1b45d9 to
a2a82bc
Compare
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
|
Thanks for this mate! awesome work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
RepositoryDiscussion,RepositoryDiscussionCommentandRepositoryDiscussionCategoryas pure GraphQL API classes. Retrieved GraphQL data with user-defined schema can be used to populate those GraphQL objects and inner REST API objects (all other existing PyGithub classes).Includes #3046 and #3047.
Fixes #2283.