Make pagination work with GraphQL response data#3047
Merged
EnricoMi merged 5 commits intoPyGithub:mainfrom Oct 28, 2024
Merged
Conversation
tiangolo
approved these changes
Oct 27, 2024
Contributor
tiangolo
left a comment
There was a problem hiding this comment.
Although I'm not part of the org, I took the liberty of reviewing this.
Looks great! 🚀 I've been using it and testing/confirming it works via #3048. I installed that branch locally and used it for my scripts.
I'm using it for automating stuff in FastAPI.
I also cloned the repo and reviewed it line by line, confirming it all made sense to me.
LGTM! 🚀
Disclaimer: I requested this feature, I want it for FastAPI's internal scripts.
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
EnricoMi
commented
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to create paginated lists of
GithubObjects from data retrieved from the GraphQL API.