Merged
Conversation
tiangolo
approved these changes
Oct 27, 2024
Contributor
tiangolo
left a comment
There was a problem hiding this comment.
I took the liberty of reviewing this. I clonned the branch locally and followed the code line by line, and it all makes sense to me. LGTM! 🚀
- use mutation name as given in Github GraphQL documentation - remove capitalized mutation name from mutation request - rename variables argument to muation_input - rename output argument to output_schema - give output schema with outer curly brackets - return response data according to output schema (drop outer data.mutationName path)
ba60442 to
2b210e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains the following breaking changes:
variablesargument tomutation_inputoutputargument tooutput_schema