Fix crash when route starts/ends at manoeuvre relation via node#7339
Merged
TheMarex merged 5 commits intoProject-OSRM:masterfrom Jan 27, 2026
Merged
Fix crash when route starts/ends at manoeuvre relation via node#7339TheMarex merged 5 commits intoProject-OSRM:masterfrom
TheMarex merged 5 commits intoProject-OSRM:masterfrom
Conversation
Member
|
Do you think there is a way to add a regression test for this to the cucumber test suite? While this may be more of a workaround I'm tempted to accept it since I don't think anyone truly understands the guidance code anymore. |
5b337d9 to
66ba9ec
Compare
DennisOSRM
approved these changes
Jan 24, 2026
MarcelloPerathoner
pushed a commit
to MarcelloPerathoner/osrm-backend
that referenced
this pull request
Feb 24, 2026
…ect-OSRM#7339) * Fix assertion failure in collapseSegregatedTurnInstructions * Add test for routes starting/ending at manoeuvre=fork via node * Skip manoeuvre overrides on depart/arrive waypoint steps * Improve the log * Fix the format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #7287
Routes starting or ending exactly at the via node of a
type=manoeuvrerelation would crash with an assertion failure.Manoeuvre overrides were applied to depart/arrive steps, setting a turn type on waypoint steps that should always have
NoTurn.post_processing.cppcollapseSegregatedTurnInstructionsas defense-in-depthTasklist
Requirements / Relations