Skip to content

Fixed instructions when starting on an internal edge#1796

Merged
dgearhart merged 2 commits intomasterfrom
gdg_start_internal_edge
May 7, 2019
Merged

Fixed instructions when starting on an internal edge#1796
dgearhart merged 2 commits intomasterfrom
gdg_start_internal_edge

Conversation

@dgearhart
Copy link
Copy Markdown
Member

@dgearhart dgearhart commented May 7, 2019 •
edited
Loading

Issue

Fixes #1794

Example#1

image

< BEFORE
< 1: Drive west on Snowden River Parkway.
< 2: You have arrived at Snowden River Parkway.
> AFTER
> 1: Drive northeast on Broken Land Parkway.
> 2: Turn left onto Snowden River Parkway.
> 3: You have arrived at Snowden River Parkway.

Example#2

image

< BEFORE
< 1: Drive southeast on Snowden River Parkway.
< 2: You have arrived at Snowden River Parkway.
> AFTER
> 1: Drive west on Snowden River Parkway.
> 2: Make a left U-turn at Broken Land Parkway to stay on Snowden River Parkway.
> 3: You have arrived at Snowden River Parkway.

Tasklist

  • Test
  • Review - you must request approval to merge any PR to master
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

@dgearhart dgearhart self-assigned this May 7, 2019
kevinkreiser
kevinkreiser reviewed May 7, 2019
View reviewed changes
Comment thread src/odin/maneuversbuilder.cc
if (prev_edge->internal_intersection() && !trip_path_->IsLastNodeIndex(node_index)) {
// Internal Intersection - excluding the first and last edges
if (prev_edge->internal_intersection() && !trip_path_->IsLastNodeIndex(node_index) &&
!trip_path_->IsFirstNodeIndex(node_index - 1)) {
Copy link
Copy Markdown
Member

@kevinkreiser kevinkreiser May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what i would have expected

@dgearhart dgearhart merged commit 1acba1d into master May 7, 2019
@dgearhart dgearhart deleted the gdg_start_internal_edge branch May 7, 2019 16:41
@afarber afarber mentioned this pull request Jan 23, 2026
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinkreiser kevinkreiser kevinkreiser approved these changes

@gknisely gknisely Awaiting requested review from gknisely

@danpaz danpaz Awaiting requested review from danpaz

Assignees

@dgearhart dgearhart

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect instructions when starting on an internal edge

2 participants

@dgearhart @kevinkreiser