Issue & Reproduction Steps

See https://processmaker.atlassian.net/browse/FOUR-16632

Pagination was not working on task saved searches. We use task saved searches extensively for default in-progress and completed tasks lists.

Solution

We had done some refactoring to improve performance but a number of these changes introduced antipatterns and broke the saved search paginations.

• https://github.com/ProcessMaker/package-savedsearch/pull/435/files
• https://github.com/ProcessMaker/package-savedsearch/pull/437/files
• https://github.com/ProcessMaker/package-savedsearch/pull/438/files
• https://github.com/ProcessMaker/processmaker/pull/6806/files
• https://github.com/ProcessMaker/processmaker/pull/6823/files

It turns out, the performance issue actually came from a code change made many years ago where we replaced paginate() with get() here: edf579f

This introduced a performance issue because it loads all tasks into memory from the database (even though it was being paginated before being sent to the front end).

Originally, this old change was made to support user filtering functionality that has sense been refactored (here) and is no longer needed.

The solution was to put back the old paginate method and remove the complicated performance logic. I also removed the user filter that is no longer needed (as mentioned above).

Because I put back paginate(), this change should maintain the performance gains we made by Alex (but we should double check).

How to Test

• Use an instance with a lot of tasks. Check that performance is still OK and that pagination works for tasks and task saved searches
• Original performance reproduction steps: FOUR-15317: Improve performance of task-related saved searches (b) #6806

Related Tickets & Packages

• REQUIRED: https://github.com/ProcessMaker/package-savedsearch/pull/449

Code Review Checklist

• I have pulled this code locally and tested it on my instance, along with any associated packages.
• This code adheres to ProcessMaker Coding Guidelines.
• This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
• This solution fixes the bug reported in the original ticket.
• This solution does not alter the expected output of a component in a way that would break existing Processes.
• This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
• This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
• This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
• This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:package-savedsearch:bugfix/FOUR-16632