Skip to content

FOUR-15317: Improve performance of task-related saved searches (b)#6806

Merged
ryancooley merged 3 commits intonextfrom
bugfix/FOUR-15317-B
May 1, 2024
Merged

FOUR-15317: Improve performance of task-related saved searches (b)#6806
ryancooley merged 3 commits intonextfrom
bugfix/FOUR-15317-B

Conversation

@runyan-co
Copy link
Copy Markdown
Contributor

@runyan-co runyan-co commented May 1, 2024

Issue

The “Completed” tasks page, which is really just a saved search specific to tasks, suffers from performance issues and has a slow response time (> 5 seconds).
ci:next

Reproduction Steps

  1. Have 500+ tasks
  2. Navigate to the tasks page (/tasks)
  3. Navigate to the “Completed Tasks” page (it’s in the sidebar on the left, small checkbox icon)
  4. Notice the slow response time while the API loads

Solution

  • Introduce missing per_page parameter to the task controller query for pagination and introduce it conditionally

How to Test

Retry the replication steps and the response time should be 2 seconds or less.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

CICD

ci:deploy
ci:next
ci:package-savedsearch:bugfix/FOUR-15317-B

.

@tokensPM
Copy link
Copy Markdown

tokensPM commented May 1, 2024

QA server K8S was successfully deployed https://ci-21b0829ccd.engk8s.processmaker.net

@runyan-co runyan-co requested review from danloa and nolanpro and removed request for danloa May 1, 2024 09:51
@tokensPM
Copy link
Copy Markdown

tokensPM commented May 1, 2024

QA server K8S was successfully deployed https://ci-21b0829ccd.engk8s.processmaker.net

@processmaker-sonarqube
Copy link
Copy Markdown

@ryancooley ryancooley merged commit 96c86ee into next May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants