Skip to content

Backport: Improve path auto-completion (#902)#916

Merged
rkeithhill merged 1 commit intoPowerShell:legacy/1.xfrom
rkeithhill:rkeithhill/cherry-pick-fix-path-auto-completions
Apr 10, 2019
Merged

Backport: Improve path auto-completion (#902)#916
rkeithhill merged 1 commit intoPowerShell:legacy/1.xfrom
rkeithhill:rkeithhill/cherry-pick-fix-path-auto-completions

Conversation

@rkeithhill
Copy link
Contributor

  • WIP: Improve path auto-completion

  • Add comment to address PR feedback

  • Address PR feedback

  • Add tests for path completion, do not do snippet completion on files

  • Fix incorrect macOS/Linxu path in completion test

* WIP: Improve path auto-completion

* Add comment to address PR feedback

* Address PR feedback

* Add tests for path completion, do not do snippet completion on files

* Fix incorrect macOS/Linxu path in completion test
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rkeithhill rkeithhill merged commit 69a1d0d into PowerShell:legacy/1.x Apr 10, 2019
@rkeithhill rkeithhill deleted the rkeithhill/cherry-pick-fix-path-auto-completions branch April 10, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants