Merged
Conversation
Member
TylerLeonhardt
left a comment
There was a problem hiding this comment.
This looks good @rkeithhill assuming I understand what's going on. We can always add more to it later but this does fix an issue that doesn't happen in the ISE.
P.S. there is a testing opportunity here for the CreateCompletionItem method 😊
src/PowerShellEditorServices.Protocol/LanguageServer/Completion.cs
Outdated
Show resolved
Hide resolved
7ff85b9 to
03593cc
Compare
src/PowerShellEditorServices.Protocol/LanguageServer/Completion.cs
Outdated
Show resolved
Hide resolved
TylerLeonhardt
approved these changes
Apr 3, 2019
Member
TylerLeonhardt
left a comment
There was a problem hiding this comment.
LGTM unless you wanted to add some tests to make sure the $0 shows up in the right place when it needs to 😄
Contributor
Author
|
This PR is ready to go. |
test/PowerShellEditorServices.Test.Host/TestFiles/CompleteFunctionName.ps1
Show resolved
Hide resolved
TylerLeonhardt
approved these changes
Apr 8, 2019
Member
|
@rkeithhill I think @rjmholt and I have decided that we, personally, will not spend the time to backport this, but if you'd like to do it, we would accept it! |
Contributor
Author
|
I'll backport it. I'd really like to have this in the next update. |
rkeithhill
added a commit
to rkeithhill/PowerShellEditorServices
that referenced
this pull request
Apr 10, 2019
* WIP: Improve path auto-completion * Add comment to address PR feedback * Address PR feedback * Add tests for path completion, do not do snippet completion on files * Fix incorrect macOS/Linxu path in completion test
rkeithhill
added a commit
that referenced
this pull request
Apr 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to determine if there are other quote scenarios where we could improve auto-completion.
Fixes PowerShell/vscode-powershell#1398