[release/v7.6] Remove unused runCodesignValidationInjection variable from pipeline templates#26707
Conversation
…emplates (PowerShell#26412) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com> Co-authored-by: Travis Plunk (HE/HIM) <tplunk@ntdev.microsoft.com>
There was a problem hiding this comment.
Pull request overview
This PR backports the removal of the unused runCodesignValidationInjection variable from multiple Azure Pipeline templates in the release/v7.6 branch. The variable was declared but never referenced in any pipeline logic.
Changes:
- Removes unused
runCodesignValidationInjectionvariable declarations from 14 pipeline template files - All removals are consistent, removing the same two-line variable declaration (name and value: false)
- No functional changes to pipeline behavior as the variable was never used
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .pipelines/templates/windows-hosted-build.yml | Removed unused variable from Windows hosted build template |
| .pipelines/templates/variable/release-shared.yml | Removed unused variable from shared release variables |
| .pipelines/templates/uploadToAzure.yml | Removed unused variable from Azure upload template |
| .pipelines/templates/testartifacts.yml | Removed unused variable from both Windows and non-Windows test artifact jobs |
| .pipelines/templates/release-upload-buildinfo.yml | Removed unused variable from build info upload template |
| .pipelines/templates/release-symbols.yml | Removed unused variable from symbols release template |
| .pipelines/templates/packaging/windows/package.yml | Removed unused variable from Windows packaging template |
| .pipelines/templates/nupkg.yml | Removed unused variable from NuGet package template |
| .pipelines/templates/mac.yml | Removed unused variable from macOS build template |
| .pipelines/templates/mac-package-build.yml | Removed unused variable from macOS package build template |
| .pipelines/templates/linux.yml | Removed unused variable from both Linux and Windows Linux-build jobs |
| .pipelines/templates/linux-package-build.yml | Removed unused variable from Linux package build template |
| .pipelines/templates/compliance/generateNotice.yml | Removed unused variable from notice generation template |
| .pipelines/templates/compliance/apiscan.yml | Removed unused variable from API scan template |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -9,8 +9,6 @@ jobs: | |||
| type: windows | |||
|
|
|||
| variables: | |||
There was a problem hiding this comment.
The cleanup of runCodesignValidationInjection is incomplete. The variable is also defined but unused in .pipelines/templates/packaging/windows/sign.yml (line 12) but was not removed in this PR. For consistency and completeness, that occurrence should also be removed.
Backport of #26412 to release/v7.6
Triggered by @daxian-dbw on behalf of @app/copilot-swe-agent
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Customer Impact
Pipeline cleanup removing unused variable declarations. This only affects internal build configuration and has no customer impact.
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
The fix has been tested in the original PR. The changes can be verified by confirming that pipelines continue to run successfully after the removal of the unused variable. Since the variable was never used, its removal has no functional effect.
Risk
REQUIRED: Check exactly one box.
The changes only remove unused variable declarations from pipeline templates. The variable runCodesignValidationInjection was defined but never referenced in any pipeline logic. This is purely cleanup with no functional impact on the build process.