Skip to content

Remove unused runCodesignValidationInjection variable from pipeline templates#26412

Merged
TravisEz13 merged 3 commits intomasterfrom
copilot/remove-unused-runcodesignvalidationinjection
Jan 14, 2026
Merged

Remove unused runCodesignValidationInjection variable from pipeline templates#26412
TravisEz13 merged 3 commits intomasterfrom
copilot/remove-unused-runcodesignvalidationinjection

Conversation

Copy link
Contributor

Copilot AI commented Nov 10, 2025

PR Summary

Removes runCodesignValidationInjection variable declarations from 14 pipeline template files. The variable was defined but never referenced in any pipeline logic.

PR Context

Cleanup of unused configuration that was likely left behind from previous pipeline changes. The variable existed in multiple templates with consistent value: false but had no consumers.

Files modified (32 lines removed):

  • .pipelines/templates/compliance/{apiscan,generateNotice}.yml
  • .pipelines/templates/{linux,mac,windows}-{package-build,hosted-build}.yml
  • .pipelines/templates/{nupkg,testartifacts,uploadToAzure}.yml
  • .pipelines/templates/release-{symbols,upload-buildinfo}.yml
  • .pipelines/templates/variable/release-shared.yml

PR Checklist

Original prompt

This section details on the original issue you should resolve

<issue_title>runCodesignValidationInjection is no longer used</issue_title>
<issue_description>### Prerequisites

Steps to reproduce

runCodesignValidationInjection is no longer used

Expected behavior

runCodesignValidationInjection is no longer used

Actual behavior

runCodesignValidationInjection is no longer used

Error details

Environment data

runCodesignValidationInjection is no longer used

Visuals

No response</issue_description>

<agent_instructions>This should only be in the .pipelines folder</agent_instructions>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…ne templates

Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove runCodesignValidationInjection as it is no longer used Remove unused runCodesignValidationInjection variable from pipeline templates Nov 10, 2025
Copilot AI requested a review from TravisEz13 November 10, 2025 19:05
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 11, 2025
@TravisEz13 TravisEz13 marked this pull request as ready for review November 11, 2025 20:14
Copilot AI review requested due to automatic review settings November 11, 2025 20:14
@TravisEz13 TravisEz13 requested a review from a team as a code owner November 11, 2025 20:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the unused runCodesignValidationInjection variable from 15 Azure Pipeline template files. The variable was consistently set to false across all files but was never referenced in any pipeline logic or scripts, making it dead code left over from previous pipeline infrastructure changes.

Key changes:

  • Removed 30 lines of unused variable declarations (2 lines per file: name + value)
  • Cleanup affects build, package, compliance, and release pipeline templates
  • One additional file (.pipelines/templates/packaging/windows/sign.yml) still contains this variable and was not included in this PR

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.pipelines/templates/windows-hosted-build.yml Removed unused variable from Windows hosted build template
.pipelines/templates/variable/release-shared.yml Removed unused variable from shared release variables
.pipelines/templates/uploadToAzure.yml Removed unused variable from Azure upload job
.pipelines/templates/testartifacts.yml Removed unused variable from both Windows and non-Windows test artifact jobs
.pipelines/templates/release-upload-buildinfo.yml Removed unused variable from build info upload job
.pipelines/templates/release-symbols.yml Removed unused variable from symbols release job
.pipelines/templates/packaging/windows/package.yml Removed unused variable from Windows packaging job
.pipelines/templates/nupkg.yml Removed unused variable from NuGet package job
.pipelines/templates/mac.yml Removed unused variable from macOS build job
.pipelines/templates/mac-package-build.yml Removed unused variable from macOS package build job
.pipelines/templates/linux.yml Removed unused variable from both Linux build jobs
.pipelines/templates/linux-package-build.yml Removed unused variable from Linux package build job
.pipelines/templates/compliance/generateNotice.yml Removed unused variable from notice generation compliance job
.pipelines/templates/compliance/apiscan.yml Removed unused variable from API scan compliance job

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Nov 19, 2025
@microsoft-github-policy-service
Copy link
Contributor

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@TravisEz13 TravisEz13 merged commit 1241ad2 into master Jan 14, 2026
45 of 46 checks passed
@TravisEz13 TravisEz13 deleted the copilot/remove-unused-runcodesignvalidationinjection branch January 14, 2026 15:58
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Jan 20, 2026
…emplates (PowerShell#26412)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Co-authored-by: Travis Plunk (HE/HIM) <tplunk@ntdev.microsoft.com>
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Feb 14, 2026
…emplates (PowerShell#26412)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Co-authored-by: Travis Plunk (HE/HIM) <tplunk@ntdev.microsoft.com>
TravisEz13 added a commit to TravisEz13/PowerShell that referenced this pull request Feb 20, 2026
…emplates (PowerShell#26412)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Co-authored-by: Travis Plunk (HE/HIM) <tplunk@ntdev.microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.4.x-Migrated Backport-7.5.x-Migrated Backport-7.6.x-Migrated CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Review - Needed The PR is being reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

runCodesignValidationInjection is no longer used

5 participants