Skip to content

Remove boost shared pointer usage and headers in favor of pcl/memory.h#3893

Merged
SergioRAgostinho merged 1 commit intoPointCloudLibrary:masterfrom
aPonza:boost
Apr 17, 2020
Merged

Remove boost shared pointer usage and headers in favor of pcl/memory.h#3893
SergioRAgostinho merged 1 commit intoPointCloudLibrary:masterfrom
aPonza:boost

Conversation

@aPonza
Copy link
Copy Markdown
Contributor

@aPonza aPonza commented Apr 8, 2020

Stems from #3750. I found more boost::shared_ptrs in the codebase. This should be the last of them, before the switch can happen. With this PR they all should be controlled from the switch in pcl/memory.h.

kunaltyagi
kunaltyagi reviewed Apr 8, 2020
View reviewed changes
@kunaltyagi kunaltyagi added changelog: fix Meta-information for changelog generation needs: author reply Specify why not closed/merged yet labels Apr 8, 2020
@kunaltyagi kunaltyagi changed the title Centralize #includes for boost::shared_ptr/make_shared Remove boost shared pointer usage and headers in favor of pcl/memory.h Apr 8, 2020
@aPonza
Copy link
Copy Markdown
Contributor Author

aPonza commented Apr 8, 2020

Is Windows CI missing Boost or am I touching something I shouldn't? link

CMake Error at C:/Program Files/CMake/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:164 (message):
  Could NOT find Boost (missing: Boost_INCLUDE_DIR filesystem date_time
  iostreams system) (Required is at least version "1.55.0")

@kunaltyagi
Copy link
Copy Markdown
Member

kunaltyagi commented Apr 8, 2020

Window CI is giving Boost troubles. Tracked by #3894

@kunaltyagi kunaltyagi added needs: code review Specify why not closed/merged yet and removed needs: author reply Specify why not closed/merged yet labels Apr 9, 2020
@kunaltyagi kunaltyagi self-requested a review April 9, 2020 12:42
@aPonza aPonza mentioned this pull request Apr 9, 2020
Merged
@taketwo
Copy link
Copy Markdown
Member

taketwo commented Apr 10, 2020

@aPonza please rebase, the Windows CI issue is solved.

@kunaltyagi
Copy link
Copy Markdown
Member

kunaltyagi commented Apr 10, 2020

👀 + 🟢 = 🚀

@SergioRAgostinho SergioRAgostinho self-requested a review April 11, 2020 11:44
@aPonza aPonza mentioned this pull request Apr 16, 2020
Merged
@aPonza
Copy link
Copy Markdown
Contributor Author

aPonza commented Apr 16, 2020

I removed the commit+revert

@SergioRAgostinho SergioRAgostinho merged commit 17a55d8 into PointCloudLibrary:master Apr 17, 2020
@aPonza aPonza deleted the boost branch April 17, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taketwo taketwo taketwo approved these changes

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

@kunaltyagi kunaltyagi kunaltyagi approved these changes

Assignees

No one assigned

Labels

changelog: fix Meta-information for changelog generation needs: code review Specify why not closed/merged yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aPonza @kunaltyagi @taketwo @SergioRAgostinho