Set BOOST_ROOT to BOOST_ROOT_1_69_0 in Azure Windows job#3894
Merged
taketwo merged 2 commits intoPointCloudLibrary:masterfrom Apr 10, 2020
Merged
Set BOOST_ROOT to BOOST_ROOT_1_69_0 in Azure Windows job#3894taketwo merged 2 commits intoPointCloudLibrary:masterfrom
taketwo merged 2 commits intoPointCloudLibrary:masterfrom
Conversation
Member
|
Same error (Boost not found) |
Member
|
Our CMake file might be relying on the env BOOST_ROOT actually being set. Setting it to %BOOST_ROOT_1_69_0% might provide the fix |
Member
|
Seems like the |
759c867 to
1a08837
Compare
Member
Author
|
Thanks for suggestions. |
kunaltyagi
approved these changes
Apr 9, 2020
Member
kunaltyagi
left a comment
There was a problem hiding this comment.
LGTM, pending CI (which appears to be going the green way)
Member
|
The CI gods are against us. I vote for merge regardless. |
Member
Author
|
We had this issue already (#2632, #2935) and according to #2935 (comment), the problem lies in Boost directories not set in the system |
One of the recent updates to the agent images used on Azure removed BOOST_ROOT variable: actions/runner-images@e91f213, however it is needed by the CMake Boost finder scripts.
kunaltyagi
approved these changes
Apr 10, 2020
Member
kunaltyagi
left a comment
There was a problem hiding this comment.
We leave the env variable printing for debugging purposes on the CI?
Member
Author
|
Yes! It's handy to have them printed always. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the recent updates to the agent images used on Azure removed BOOST_ROOT variable: actions/runner-images@e91f213