Android fix #8
Merged
Android fix #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing exception handling for socket preventing unexpected app crash
Exposing Static functions for NDK, which are otherwise not accessble to JNI, thereby preventing app crash
Fixing functions invocation post onCreate which are otherwise unavailable pre onCreate, preventing app crash
ShootingKing-AM
added a commit
that referenced
this pull request
Jan 28, 2021
Crash stacktrace:
```ml
pid: 10065, tid: 10136, name: GLThread 235 >>> viritualisres.phonevr <<<
uid: 10155
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x8
Cause: null pointer dereference
eax 00257100 ebx da946db4 ecx 00000008 edx 00000002
edi ac68dbb0 esi 00000080
ebp ac68d948 esp ac68d910 eip da7e04fb
backtrace:
#00 pc 000de4fb /system/lib/libndk_translation.so (ndk_translation::InsnInterpreter::FaultyStore(ndk_translation::DecoderReg, ndk_translation::DecoderReg)+395) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
#1 pc 000e1dc6 /system/lib/libndk_translation.so (ndk_translation::(anonymous namespace)::ArmInterpreter::GenFaultyStore(int, int)+54) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
#2 pc 000f6a68 /system/lib/libndk_translation.so (ndk_translation::SemanticsDecoder::STR_immediate(ndk_translation::STR_immediate_Args const&)+744) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
#3 pc 0012cf9b /system/lib/libndk_translation.so (ndk_translation::ArmDecoder::TranslateThumbInsn(unsigned short const*)+5995) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
#4 pc 000e1700 /system/lib/libndk_translation.so (ndk_translation::(anonymous namespace)::DecodeInsn(unsigned int, ndk_translation::(anonymous namespace)::ArmInterpreter*, ndk_translation::ProcessState*, ndk_translation::ArmDecoder*)+128) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
#5 pc 000e1934 /system/lib/libndk_translation.so (ndk_translation::InterpretTrace(ndk_translation::ProcessState*)+340) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
#6 pc 000d1b32 /system/lib/libndk_translation.so (ndk_translation_HandleNotTranslated+194) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
#7 pc 000cfffa /system/lib/libndk_translation.so (ndk_translation::ExecuteGuest(ndk_translation::ProcessState*, unsigned int)+266) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
#8 pc 000d0274 /system/lib/libndk_translation.so (ndk_translation::(anonymous namespace)::RunGuestCall(unsigned int, int, int, unsigned int*)+260) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
#9 pc 000d0399 /system/lib/libndk_translation.so (ndk_translation::GuestCall::RunResInt32(unsigned int)+41) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
#10 pc 000cda44 /system/lib/libndk_translation.so (ndk_translation::(anonymous namespace)::RunGuestThread(void*)+164) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
#11 pc 000e42c4 /apex/com.android.runtime/lib/bionic/libc.so (__pthread_start(void*)+100) (BuildId: 57f4eb5e1df9fa8bd21032ad6be9823f)
#12 pc 000785f7 /apex/com.android.runtime/lib/bionic/libc.so (__start_thread+71) (BuildId: 57f4eb5e1df9fa8bd21032ad6be9823f)
```
Updating ndk to r22 fixes this crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relocating calls post onCreate, Network socket exception handling and exposing static functions to JNI