Skip to content

Conversation

@thezofx
Copy link
Contributor

@thezofx thezofx commented Aug 1, 2020

…rt, and adding flags to cmake

  1. Added GoogleVR x86 Library files from (https://github.com/googlevr/gvr-android-sdk) v1.200.
  2. Changed Text color to White in order to make PhoneVR (text) and Settings text (options) visible in App.
  3. Added flags to cmake in order to suppress warning while gradle build.
  4. Removed x86 from .gitignore to make git detect added x86 library files.

…rt, and adding flags to cmake

1. Add GoogleVR x86 Library files from  (https://github.com/googlevr/gvr-android-sdk) v1.200.
2. Changed Text color to White in order to make PhoneVR (text) and Settings (options) visible in App.
3. added flags to cmake in order to supress warning while gradle build.
4.. removed x86 from .gitignore to make git detect my added x86 library files.
@ShootingKing-AM ShootingKing-AM added the enhancement feature improvement or request label Aug 1, 2020
@ShootingKing-AM ShootingKing-AM self-assigned this Aug 1, 2020
Copy link
Member

@ShootingKing-AM ShootingKing-AM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes

edited as per @ShootingKing-AM suggested
@ShootingKing-AM ShootingKing-AM merged commit 358bcae into PhoneVR-Developers:master Aug 1, 2020
ShootingKing-AM added a commit that referenced this pull request Jan 28, 2021
Crash stacktrace:
```ml
pid: 10065, tid: 10136, name: GLThread 235  >>> viritualisres.phonevr <<<
uid: 10155
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x8
Cause: null pointer dereference
    eax 00257100  ebx da946db4  ecx 00000008  edx 00000002
    edi ac68dbb0  esi 00000080
    ebp ac68d948  esp ac68d910  eip da7e04fb

backtrace:
      #00 pc 000de4fb  /system/lib/libndk_translation.so (ndk_translation::InsnInterpreter::FaultyStore(ndk_translation::DecoderReg, ndk_translation::DecoderReg)+395) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
      #1 pc 000e1dc6  /system/lib/libndk_translation.so (ndk_translation::(anonymous namespace)::ArmInterpreter::GenFaultyStore(int, int)+54) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
      #2 pc 000f6a68  /system/lib/libndk_translation.so (ndk_translation::SemanticsDecoder::STR_immediate(ndk_translation::STR_immediate_Args const&)+744) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
      #3 pc 0012cf9b  /system/lib/libndk_translation.so (ndk_translation::ArmDecoder::TranslateThumbInsn(unsigned short const*)+5995) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
      #4 pc 000e1700  /system/lib/libndk_translation.so (ndk_translation::(anonymous namespace)::DecodeInsn(unsigned int, ndk_translation::(anonymous namespace)::ArmInterpreter*, ndk_translation::ProcessState*, ndk_translation::ArmDecoder*)+128) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
      #5 pc 000e1934  /system/lib/libndk_translation.so (ndk_translation::InterpretTrace(ndk_translation::ProcessState*)+340) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
      #6 pc 000d1b32  /system/lib/libndk_translation.so (ndk_translation_HandleNotTranslated+194) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
      #7 pc 000cfffa  /system/lib/libndk_translation.so (ndk_translation::ExecuteGuest(ndk_translation::ProcessState*, unsigned int)+266) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
      #8 pc 000d0274  /system/lib/libndk_translation.so (ndk_translation::(anonymous namespace)::RunGuestCall(unsigned int, int, int, unsigned int*)+260) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
      #9 pc 000d0399  /system/lib/libndk_translation.so (ndk_translation::GuestCall::RunResInt32(unsigned int)+41) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
      #10 pc 000cda44  /system/lib/libndk_translation.so (ndk_translation::(anonymous namespace)::RunGuestThread(void*)+164) (BuildId: 1962273ccbeb69757878abf4e17d95aa)
      #11 pc 000e42c4  /apex/com.android.runtime/lib/bionic/libc.so (__pthread_start(void*)+100) (BuildId: 57f4eb5e1df9fa8bd21032ad6be9823f)
      #12 pc 000785f7  /apex/com.android.runtime/lib/bionic/libc.so (__start_thread+71) (BuildId: 57f4eb5e1df9fa8bd21032ad6be9823f)
```

Updating ndk to r22 fixes this crash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement feature improvement or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants