Extract DeclareParenthesesFixer from BracesFixer#5751
Extract DeclareParenthesesFixer from BracesFixer#5751keradus merged 2 commits intoPHP-CS-Fixer:masterfrom
Conversation
d16c132 to
b973f9f
Compare
| public function getDefinition(): FixerDefinitionInterface | ||
| { | ||
| return new FixerDefinition( | ||
| 'There must not be spaces around `declare` statement braces.', |
There was a problem hiding this comment.
around braces or inside parenthesis ?
There was a problem hiding this comment.
to my understanding, braces means {/}
in PHP CS Fixer, for ( / ) we were using parentheses.
i will lat myself apply the rename
There was a problem hiding this comment.
to my understanding,
bracesmeans{/}
in PHP CS Fixer, for(/)we were using parentheses.
if we were that consistent - we have curly braces even in some fixer name
GrahamCampbell
left a comment
There was a problem hiding this comment.
Great job. Should we add config to the braces fixer to get it to not proxy the fixer, so we can deprecate it doing that for removal in next major?
|
I am not suggesting deprecating the braces fixer. I'm suggesting deprecating the option in the braces fixer that proxies declare_braces. |
|
Oh ok. Well, since the point is to deprecate the rule entirely, I'm not sure it's worth the hassle. |
95e8508 to
abda6cd
Compare
abda6cd to
a2f9c23
Compare
|
Thank you @julienfalque. |
Extracted from #4884.