Skip to content

minor: Deprecate BracesFixer#4885

Merged
keradus merged 2 commits intoPHP-CS-Fixer:masterfrom
julienfalque:split-braces-fixer-master
Mar 31, 2023
Merged

minor: Deprecate BracesFixer#4885
keradus merged 2 commits intoPHP-CS-Fixer:masterfrom
julienfalque:split-braces-fixer-master

Conversation

@julienfalque
Copy link
Copy Markdown
Member

@julienfalque julienfalque commented Mar 16, 2020 •
edited by keradus
Loading

TODO

@julienfalque julienfalque force-pushed the split-braces-fixer-master branch from 934135c to 5dad50f Compare March 18, 2020 12:14
@julienfalque
Copy link
Copy Markdown
Member Author

julienfalque commented Mar 18, 2020 •
edited
Loading

Current Travis failure seems to be a bug in PHP. I have submitted a bug report on PHP tracker.

This was referenced Mar 18, 2020
Closed
Merged
This was referenced May 2, 2020
Closed
Closed
@julienfalque julienfalque mentioned this pull request Jul 3, 2020
Closed
@keradus keradus changed the base branch from master to 2.19 May 3, 2021 22:07
@matt-allan matt-allan mentioned this pull request May 4, 2021
Closed
@julienfalque julienfalque changed the base branch from 2.19 to master May 6, 2021 14:48
@julienfalque julienfalque force-pushed the split-braces-fixer-master branch from 5dad50f to 0bbcd4c Compare May 6, 2021 15:15
@coveralls
Copy link
Copy Markdown

coveralls commented May 6, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.005%) to 92.84% when pulling e3c91a7 on julienfalque:split-braces-fixer-master into e59005d on FriendsOfPHP:master.

@julienfalque julienfalque mentioned this pull request May 15, 2021
Closed
@salarmehr
Copy link
Copy Markdown

salarmehr commented Jul 20, 2021

Any update about this PR?

@kubawerlos
Copy link
Copy Markdown
Member

kubawerlos commented Jul 20, 2021

@salarmehr Julien extracted 1st fixer to #5751 - do not hesitate and make a proper review there.

@julienfalque julienfalque mentioned this pull request Aug 23, 2021
Merged
@julienfalque julienfalque mentioned this pull request Sep 2, 2021
Merged
@julienfalque julienfalque force-pushed the split-braces-fixer-master branch 2 times, most recently from 93697e3 to 9056eb6 Compare September 5, 2021 12:31
@julienfalque julienfalque force-pushed the split-braces-fixer-master branch from 9056eb6 to 8a8acf1 Compare August 6, 2022 15:39
@julienfalque julienfalque changed the title Deprecate BracesFixer minor: Deprecate BracesFixer Aug 6, 2022
@keradus
Copy link
Copy Markdown
Member

keradus commented Aug 17, 2022

@julienfalque , please go ahead with this one! :) all else got merged!

@jrmajor
Copy link
Copy Markdown
Contributor

jrmajor commented Aug 18, 2022

Deprecate SingleSpaceAfterConstructFixer in favor of a new SingleSpaceAroundConstructFixer that would also fix space before the use keyword for anonymous functions.

If SingleSpaceAroundConstructFixer also handled spacing around the fn and => in arrow functions, it would be useful for #6547.

@julienfalque julienfalque force-pushed the split-braces-fixer-master branch from 8a8acf1 to e3c91a7 Compare August 19, 2022 16:44
@keradus
Copy link
Copy Markdown
Member

keradus commented Oct 12, 2022

@julienfalque , do you think we can finalise this PR?
I would love to see it merged!

@julienfalque
Copy link
Copy Markdown
Member Author

julienfalque commented Oct 12, 2022

It's still WIP on my laptop, have to find some time to 🙂

@julienfalque julienfalque mentioned this pull request Oct 27, 2022
Closed
@keradus
Copy link
Copy Markdown
Member

keradus commented Oct 27, 2022

eager to see that happening ! take your time ;)

@keradus keradus merged commit 64ec91d into PHP-CS-Fixer:master Mar 31, 2023
@keradus keradus mentioned this pull request Mar 31, 2023
Closed
@keradus
Copy link
Copy Markdown
Member

keradus commented Mar 31, 2023

I know that this PR looks small and simple, but only because most of work to make this happen got extracted to smaller, independent PRs [for easier review and faster merge].

Kudos for making all of that happen, @julienfalque ! that was one of the biggest effort we had in whole Fixer project!

@kubawerlos
Copy link
Copy Markdown
Member

kubawerlos commented Mar 31, 2023

Go away, you evil fixer 🍾

This was referenced Mar 31, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@keradus
Copy link
Copy Markdown
Member

keradus commented Apr 2, 2023

I think that was one of the oldest fixer we ever had.

and one of first ones that I created. #472

it took ages to have it in shape that was allowing to merge it. so many things learnt during that. time for retire indeed

@julienfalque julienfalque deleted the split-braces-fixer-master branch April 3, 2023 06:51
@julienfalque
Copy link
Copy Markdown
Member Author

julienfalque commented Apr 3, 2023

Thank you @keradus for finishing this!

This was referenced Apr 4, 2023
Closed
Closed
Closed
vudaltsov added a commit to phpyh/coding-standard that referenced this pull request Apr 25, 2023
@vudaltsov
Remove braces config
732ca23 
See PHP-CS-Fixer/PHP-CS-Fixer#4885
@localheinz localheinz mentioned this pull request Apr 27, 2023
Merged
5 tasks
This was referenced May 12, 2023
Closed
Closed
Closed
Closed
Closed
@Wirone Wirone mentioned this pull request Jun 7, 2023
Open
@Wirone Wirone mentioned this pull request Jul 25, 2023
Closed
@gharlan gharlan mentioned this pull request Jan 4, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wirone Wirone Wirone approved these changes

@kubawerlos kubawerlos Awaiting requested review from kubawerlos

Assignees

No one assigned

Labels

kind/deprecation kind/refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@julienfalque @coveralls @salarmehr @kubawerlos @keradus @jrmajor @Wirone