Conversation
9202f6e to
7bcb815
Compare
b157f90 to
68073c2
Compare
e528fc9 to
9cb884b
Compare
9cb884b to
e9f4820
Compare
|
Hoping for progress on this for comments and php open tag issues. Details here: |
2013401 to
a74eeea
Compare
9c336d3 to
456f1af
Compare
|
This PR is now small enough to be reviewed directly IMO. |
456f1af to
7ca35ed
Compare
| continue; | ||
| } | ||
|
|
||
| $pos = strrpos($content, "\n"); |
There was a problem hiding this comment.
is this a clean up or can we maybe add a utest for this change to NoExtraBlankLinesFixerTest as well?
There was a problem hiding this comment.
This is only a refactoring that shouldn't change behavior.
keradus
left a comment
There was a problem hiding this comment.
So big effort, in this and extracted PRs!
big, big kudos, @julienfalque !
|
Thanks for the split 👍 It will be helfpul in narrowing down changes and bugs! It seems this split broke indent of catch/switch. I tried the latest 3.9.x and these worked. -switch ($simple) {\n
+switch($simple) {\n-} catch (FirstThrowableType $e) {\n
+} catch(FirstThrowableType $e) {\n new class($a, $b, $c) extends SomeExtendedClass implements\n
\ArrayAccess,\n
\Countable {\n
- // Body\n
- };\n
+ // Body\n
+};\n |
|
Allright, add |
|
@TomasVotruba Third case looks expected though. |
|
@julienfalque I see people complaining PSR12 set is now broken :) How can I make it 3.9 compatible? |
|
@TomasVotruba Please submit an issue with details regarding what is broken. |
|
@julienfalque <?php
class Foo
{
public function test()
{
}
}it will be fixed before v3.10.0, but it doesn't fix now. This PR is big change, so I not found where line has a problem |
|
|
@kayw-geek , would you mind to open new issue and link this PR? not so many ppl are watching the closed issues/PRs |
|
First of all, thank you very much for your great work. |
|
No, the rules created during this refactoring only cover existing behaviour of |
|
But if you will pay attention to comment #4487? This comment is already 3 years old, please, this functionality is necessary to improve the code's readability. |
|
I don't believe we ever provided this feature, and it's not related to split of Braces fixer. if you would like to provide such feature, please show it's needed by given community [eg some big open source project/framework] and propose a PR for it, thanks ! |
Fixes #823, #776, #4950, #5115 and #6519; replaces #4721.
Extracted: