Skip to content

minor: extract NoMultipleStatementsPerLineFixer from BracesFixer#6458

Merged
julienfalque merged 3 commits intoPHP-CS-Fixer:masterfrom
julienfalque:split-braces-fixer-extract
Jul 21, 2022
Merged

minor: extract NoMultipleStatementsPerLineFixer from BracesFixer#6458
julienfalque merged 3 commits intoPHP-CS-Fixer:masterfrom
julienfalque:split-braces-fixer-extract

Conversation

@julienfalque
Copy link
Copy Markdown
Member

Extracted from #4884.

@julienfalque julienfalque mentioned this pull request Jul 5, 2022
6 tasks
@julienfalque julienfalque force-pushed the split-braces-fixer-extract branch from 5bf4a56 to f455372 Compare July 5, 2022 18:39
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 5, 2022

Coverage Status

Coverage increased (+0.005%) to 92.903% when pulling 72a4b81 on julienfalque:split-braces-fixer-extract into f408220 on FriendsOfPHP:master.

@mvorisek
Copy link
Copy Markdown
Contributor

why there is no code removed from BracesFixer?

@julienfalque julienfalque force-pushed the split-braces-fixer-extract branch from f455372 to feea121 Compare July 15, 2022 17:29
@julienfalque
Copy link
Copy Markdown
Member Author

I made some cleanup :)

@julienfalque julienfalque force-pushed the split-braces-fixer-extract branch from feea121 to 06711c1 Compare July 15, 2022 17:57
@julienfalque
Copy link
Copy Markdown
Member Author

Now I remember why: some integration tests fail when removing this code. This requires more work from #4884.

@SpacePossum
Copy link
Copy Markdown
Contributor

looking good, please consider julienfalque#12

@julienfalque julienfalque force-pushed the split-braces-fixer-extract branch from 1a027e4 to 72a4b81 Compare July 21, 2022 18:11
@julienfalque julienfalque merged commit 505adc1 into PHP-CS-Fixer:master Jul 21, 2022
@julienfalque julienfalque deleted the split-braces-fixer-extract branch July 21, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants