inserted missing implementation for some GameAction subclasses#13616
inserted missing implementation for some GameAction subclasses#13616csunday95 wants to merge 57 commits into
Conversation
This can be used in conjuction with OpenRCT2#13593 to change the placement of vehicles on a track
|
|
||
| void StaffSetNameAction::AcceptParameters(GameActionParameterVisitor& visitor) | ||
| { | ||
| visitor.Visit("spriteIndex", _spriteIndex); |
There was a problem hiding this comment.
I think just id would be better than spriteIndex. We no longer refer to entities as sprites.
There was a problem hiding this comment.
In GuestSetNameAction we used peep
There was a problem hiding this comment.
I just selected spriteIndex to line up with the member name, would it be preferred to have a more human readable name like "peep" or "peepId" (or perhaps "staffId") for the outward facing API?
There was a problem hiding this comment.
I think peep would be a best. There are at least 2 other actions that use that.
Feature/rct1 surfaces
* fix for bug OpenRCT2#13611; handled too few sig figs fixed point case * added unit test cases to cover modified fixed point code * removed blank line to satistfy clang-format * sorted includes in formatting tests for clang-format * removed redundant static_cast - already a char literal and assigning to char[] so code is functionally equivalent
| uint32_t flags = GetFlags(); | ||
|
|
||
| if (!(GetFlags() & (GAME_COMMAND_FLAG_ALLOW_DURING_PAUSED | GAME_COMMAND_FLAG_GHOST))) | ||
| if (!(flags & (GAME_COMMAND_FLAG_ALLOW_DURING_PAUSED | GAME_COMMAND_FLAG_GHOST))) |
There was a problem hiding this comment.
don't make unrelated changes in this PR save it for a different PR.
There was a problem hiding this comment.
wait... how did this end up here? dang I think I must have been working on the wrong local branch when I was investigating something. I'll revert this on my next commit to this PR
…g enum (OpenRCT2#13103) Merge MISC_COMMAND and GAME_COMMAND enums Cleanup
Handle multi-byte RCT2 strings when converting to string_view.
- added deserializer for MapRange to GameAction.h - added AcceptParameters implemetnation for ClearAction
…y95/OpenRCT2 into fix-13615-incomplete-game-actions
|
ah shoot I seem to have messed up this PR while trying to rebase something else; not sure what to do in this situation since I committed on top of the rebase and pushed. Might just be best to close this PR and redo it from scratch? redoing these changes is pretty trivial with PR this as a reference |
|
Just do a rebase of develop. It will remove all of the merge related commits that you have added and keep only your changes. |
* Simplify paint session generate * Add template to improve performance * Add comments and fix minor issues
- added deserializer for MapRange to GameAction.h - added AcceptParameters implemetnation for ClearAction
…y95/OpenRCT2 into fix-13615-incomplete-game-actions
- added deserializer for MapRange to GameAction.h - added AcceptParameters implemetnation for ClearAction
…y95/OpenRCT2 into fix-13615-incomplete-game-actions
Creating pull request for fixing issue #13615
So far only has SetStaffNameAction implementation, but am planning to browse through the actions and see if any others need the same additions