WIP: Closes #12419: Combine MISC_COMMAND and GAME_COMMAND into strong enum#13103
Merged
Conversation
n7st
commented
Oct 6, 2020
n7st
left a comment
Contributor
Author
There was a problem hiding this comment.
There are a few unknowns here still. I'm working through testing.
Contributor
|
I think the changes should be reverted back to using a specific enum for the time being, ideally we refactor the network packets later to have individual packets rather than one packet with a sub command. |
Contributor
|
The PR looks alright, the CI is currently failing due to the commit messages? I have no objections to merge this as is, the special game commands needs fixing after this PR. |
Member
|
Please rebase to drop the merge commit and fold the fourth one into one of the others, this will solve the lint commit problem. Also, one of the debug builds failed with: Which is a bit suspicious |
Member
Contributor
Author
Merge MISC_COMMAND and GAME_COMMAND enums Cleanup
tupaschoal
approved these changes
Dec 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request reconciles MISC_COMMAND and GAME_COMMAND, refactoring them both to use strong enums. I'm currently testing the changes.
Thanks!