GameActions cleanup #1#13184
Merged
Merged
Conversation
Gymnasiast
reviewed
Oct 14, 2020
Gymnasiast
reviewed
Oct 14, 2020
Gymnasiast
left a comment
Member
There was a problem hiding this comment.
Looks all right to me, but would like an approval of a team member who has done more with multiplayer.
tupaschoal
approved these changes
Oct 15, 2020
tupaschoal
left a comment
Member
There was a problem hiding this comment.
renames GA_ERROR to GameActions::Status
THANK YOU! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is pretty minor, it renames GA_ERROR to GameActions::Status and GA_FLAGS into GameActions::Flags and make it more consistent with our style.