Paint Setup refactor#13633
Merged
Merged
Conversation
tupaschoal
approved these changes
Dec 23, 2020
tupaschoal
left a comment
Member
There was a problem hiding this comment.
Hmm, I guess the end result is indeed a bit clearer to follow. I look at each commit and it looks ok
Contributor
Author
|
I made a slight mistake in the middle commits but it was corrected at the end. I think there is two rotations of the coordinates. |
Member
|
Yea, I noticed that and the casts coming back |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst implementing the same function for OpenLoco I noticed an opertunity to simplify the Paint Generate code. Then of course there was poor performance so had to introduce the template version to simplify the execution. Comments welcome to if this is easier to understand or not.