Evaluating https issues in CircleCI (on top of CiscoM31-maven-https#5034
Merged
jimschubert merged 5 commits intomasterfrom Jan 18, 2020
Merged
Evaluating https issues in CircleCI (on top of CiscoM31-maven-https#5034jimschubert merged 5 commits intomasterfrom
jimschubert merged 5 commits intomasterfrom
Conversation
Closed
5 tasks
Member
Author
|
@sebastien-rosset circleci looks good now. Thanks for working to get that fixed! |
jimschubert
added a commit
that referenced
this pull request
Jan 19, 2020
* master: Evaluating https issues in CircleCI (on top of CiscoM31-maven-h… (#5034)
jimschubert
added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Jan 19, 2020
This continues on work in OpenAPITools#5033 and OpenAPITools#5034 which convert all http usage to https to unblock CircleCI builds. In OpenAPITools#5034, mavenCentral() DSL was updated to explicitly target the https maven repo because Gradle didn't force TLS 1.2 until v4.8.1 and many of our examples use earlier versions of Gradle. The Kotlin meta generator was missed because it is a .kts build file rather than build.gradle, and the mustache filename doesn't have kts in it; the file was updated as if it was build.gradle (groovy syntax).
5 tasks
jimschubert
added a commit
that referenced
this pull request
Jan 19, 2020
This continues on work in #5033 and #5034 which convert all http usage to https to unblock CircleCI builds. In #5034, mavenCentral() DSL was updated to explicitly target the https maven repo because Gradle didn't force TLS 1.2 until v4.8.1 and many of our examples use earlier versions of Gradle. The Kotlin meta generator was missed because it is a .kts build file rather than build.gradle, and the mustache filename doesn't have kts in it; the file was updated as if it was build.gradle (groovy syntax).
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.