[CORE] replace http with https. Replace http://central.maven.org with https:repo1.maven.org#5033
Closed
sebastien-rosset wants to merge 2 commits intoOpenAPITools:masterfrom
Closed
[CORE] replace http with https. Replace http://central.maven.org with https:repo1.maven.org#5033sebastien-rosset wants to merge 2 commits intoOpenAPITools:masterfrom
sebastien-rosset wants to merge 2 commits intoOpenAPITools:masterfrom
Conversation
jimschubert
reviewed
Jan 18, 2020
Member
jimschubert
left a comment
There was a problem hiding this comment.
LGTM there's an additional issue but I'll fix it with yours in #5033
| If you're looking for the latest stable version, you can grab it directly from Maven.org (Java 8 runtime at a minimum): | ||
|
|
||
| JAR location: `http://central.maven.org/maven2/org/openapitools/openapi-generator-cli/3.3.4/openapi-generator-cli-3.3.4.jar` | ||
| JAR location: `https://repo1.maven.org/maven2/org/openapitools/openapi-generator-cli/3.3.4/openapi-generator-cli-3.3.4.jar` |
Member
There was a problem hiding this comment.
Hm. We need to update this file in a separate PR to to replace the doc version via script.
Member
|
I'm going to close this in favor of #5034. I copied the wring PR number in my LGTM comment. ❌ Additional issue is |
jimschubert
added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Jan 19, 2020
This continues on work in OpenAPITools#5033 and OpenAPITools#5034 which convert all http usage to https to unblock CircleCI builds. In OpenAPITools#5034, mavenCentral() DSL was updated to explicitly target the https maven repo because Gradle didn't force TLS 1.2 until v4.8.1 and many of our examples use earlier versions of Gradle. The Kotlin meta generator was missed because it is a .kts build file rather than build.gradle, and the mustache filename doesn't have kts in it; the file was updated as if it was build.gradle (groovy syntax).
5 tasks
jimschubert
added a commit
that referenced
this pull request
Jan 19, 2020
This continues on work in #5033 and #5034 which convert all http usage to https to unblock CircleCI builds. In #5034, mavenCentral() DSL was updated to explicitly target the https maven repo because Gradle didn't force TLS 1.2 until v4.8.1 and many of our examples use earlier versions of Gradle. The Kotlin meta generator was missed because it is a .kts build file rather than build.gradle, and the mustache filename doesn't have kts in it; the file was updated as if it was build.gradle (groovy syntax).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to eliminate the use of http as much as possible.
Some of these changes are documentation only and do not affect the build but we should use https nonetheless.
There are multiple use of http://central.maven.org, but that site returns error 403 with a message stating to use http://repo1.maven.org. I've replaced these.
There are some http URL that don't exist anymore. I'm not sure what to do about it, and it's not clear they are used anyway.
I did a cursory search to find use of http://:
Right now it yields over 6000 results. Unfortunately we can't do a simple search and replace.
Slightly better way to find references to http://
It yields 779 results.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.