Skip to content

[csharp] Adding http response details on api_docs and making example snippet compilable#3129

Merged
wing328 merged 6 commits intoOpenAPITools:masterfrom
saigiridhar21:feat/documentation/response-details
Jun 24, 2019
Merged

[csharp] Adding http response details on api_docs and making example snippet compilable#3129
wing328 merged 6 commits intoOpenAPITools:masterfrom
saigiridhar21:feat/documentation/response-details

Conversation

@saigiridhar21
Copy link
Contributor

@saigiridhar21 saigiridhar21 commented Jun 9, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

Closes:#3131
Closes:#3132

@mandrean (2017/08), @jimschubert (2017/09)

@auto-labeler
Copy link

auto-labeler bot commented Jun 9, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@saigiridhar21 saigiridhar21 changed the title [csharp] Adding http response details on api_docs [csharp] Adding http response details on api_docs and making example snippet compilable Jun 9, 2019
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 2773b32 into OpenAPITools:master Jun 24, 2019
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Jun 24, 2019
* master:
  Ruby-client: Don't encode slashes if strict-spec false (OpenAPITools#3204)
  [openapi-yaml] Config option outputFile was ignored by the generator. (OpenAPITools#3199)
  Add missing javax dependencies for Java > 8 (OpenAPITools#3188)
  update kotlin samples
  Minor fix to presentation link
  Add Flow import to kotlin spring reactive (OpenAPITools#3107)
  Ktor Fix KtorExperimentalAPI import (OpenAPITools#3108)
  Add a link to the speaker deck at Kubernetes Contributor Summit (OpenAPITools#3205)
  [csharp] Adding http response details on api_docs and making example snippet compilable (OpenAPITools#3129)
  [java][jesery2]: "InjectionManagerFactory not found" issue (OpenAPITools#3153)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants