Add Flow import to kotlin spring reactive#3107
Merged
wing328 merged 5 commits intoOpenAPITools:masterfrom Jun 24, 2019
Merged
Conversation
sylvainmoindron
suggested changes
Jun 5, 2019
| */ | ||
| @Test | ||
| fun {{operationId}}Test() { | ||
| fun {{operationId}}Test() = runBlockingTest { |
Contributor
There was a problem hiding this comment.
on non reactive this test will not compile because the import runBlockingTest is not done.
maybe
fun {{operationId}}Test() {{#reactive}}= runBlockingTest {{/reactive}}{
sylvainmoindron
suggested changes
Jun 5, 2019
Contributor
sylvainmoindron
left a comment
There was a problem hiding this comment.
generate also the "kotlin-springboot" sample (the two non-reactive/reactive are heavily linked)
Contributor
Author
|
I have run |
Contributor
|
it'q seems good to me |
jimschubert
added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Jun 24, 2019
* master: Ruby-client: Don't encode slashes if strict-spec false (OpenAPITools#3204) [openapi-yaml] Config option outputFile was ignored by the generator. (OpenAPITools#3199) Add missing javax dependencies for Java > 8 (OpenAPITools#3188) update kotlin samples Minor fix to presentation link Add Flow import to kotlin spring reactive (OpenAPITools#3107) Ktor Fix KtorExperimentalAPI import (OpenAPITools#3108) Add a link to the speaker deck at Kubernetes Contributor Summit (OpenAPITools#3205) [csharp] Adding http response details on api_docs and making example snippet compilable (OpenAPITools#3129) [java][jesery2]: "InjectionManagerFactory not found" issue (OpenAPITools#3153)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Must fix #3106
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
Add import and runBlockingTest.
Also, add the sh to ensure-up-to-date because a lot of change on samples are from another fix.
@jimschubert
@dr4ke616
@karismann
@sylvainmoindron as coroutines generator author.