Skip to content

Modify validateGenesisAssertion to handle non-empty genesis#4031

Merged
tsahee merged 3 commits into
masterfrom
validate-non-empty-genesis
Nov 19, 2025
Merged

Modify validateGenesisAssertion to handle non-empty genesis#4031
tsahee merged 3 commits into
masterfrom
validate-non-empty-genesis

Conversation

@amsanghi

Copy link
Copy Markdown
Contributor

No description provided.

@amsanghi amsanghi requested a review from tsahee November 19, 2025 13:48
@amsanghi amsanghi marked this pull request as ready for review November 19, 2025 13:48
@amsanghi amsanghi changed the title Validate non empty genesis Modify validateGenesisAssertion to handle non-empty genesis Nov 19, 2025

@joshuacolvin0 joshuacolvin0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actions Bot commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
2172 4 2168 0
View the top 3 failed tests by shortest run time
TestBroadcastClientConfirmedMessage
Stack Traces | 5.020s run time
=== RUN   TestBroadcastClientConfirmedMessage
=== PAUSE TestBroadcastClientConfirmedMessage
=== CONT  TestBroadcastClientConfirmedMessage
INFO [11-19|15:50:14.242] arbitrum websocket broadcast server is listening address=[::]:36327
    broadcastclient_test.go:315: broadcasting seq 0 message
INFO [11-19|15:50:14.242] connecting to arbitrum inbox message broadcaster url=ws://127.0.0.1:36327/
    broadcastclient_test.go:325: Received Message, Sequence Message: {0 {0xc000420f90 0} <nil> [65 5 246 139 242 39 152 118 203 82 181 188 21 106 160 35 208 153 56 48 175 146 141 57 119 243 95 83 79 124 60 173 60 1 162 240 162 205 203 77 44 203 151 130 203 191 35 188 67 71 152 18 100 241 114 184 72 11 48 176 18 39 241 21 0] [] 0}
INFO [11-19|15:50:14.253] Feed connected                           feedServerVersion=2 chainId=8744 requestedSeqNum=0
WARN [11-19|15:50:14.256] confirmed sequence number is past the end of stored messages "confirmed sequence number"=42 "last stored sequence number"=0
    broadcastclient_test.go:346: Client did not receive confirm message
--- FAIL: TestBroadcastClientConfirmedMessage (5.02s)
TestVersion40
Stack Traces | 8.039s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
=== PAUSE TestVersion40
=== CONT  TestVersion40
    precompile_inclusion_test.go:90: goroutine 455616 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.4/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40e3250, 0xc0232fcc40}, {0x40a0aa0, 0xc11626f2c0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc0232fcc40, {0x40a0aa0, 0xc11626f2c0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1759 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc0232fcc40, 0x28, {0xc0b4981df8, 0x5, 0x38?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion40(0xc0232fcc40?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:71 +0x64b
        testing.tRunner(0xc0232fcc40, 0x3d274d0)
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion40 (8.04s)
TestAuctioneerFailover_MultipleInstances
Stack Traces | 16.059s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [11-19|15:51:49.126] Imported new potential chain segment     number=16 hash=edd1d3..9572de blocks=1 txs=1 mgas=0.979 elapsed=1.106ms     mgasps=885.211  triediffs=38.80KiB triedirty=0.00B
INFO [11-19|15:51:49.127] Chain head was updated                   number=16 hash=edd1d3..9572de root=dff107..ccb02c elapsed="84.557µs"
    auctioneer_failover_test.go:45: 
        	Error Trace:	/home/runner/work/nitro/nitro/timeboost/auctioneer_failover_test.go:45
        	            				/home/runner/work/nitro/nitro/timeboost/auctioneer_failover_test.go:158
        	Error:      	Received unexpected error:
        	            	invalid length, need 256 bits
        	            	opening wallet
        	            	github.com/offchainlabs/nitro/timeboost.NewAuctioneerServer
        	            		/home/runner/work/nitro/nitro/timeboost/auctioneer.go:207
        	            	github.com/offchainlabs/nitro/timeboost.createAndStartAuctioneer
        	            		/home/runner/work/nitro/nitro/timeboost/auctioneer_failover_test.go:44
        	            	github.com/offchainlabs/nitro/timeboost.TestAuctioneerFailover_MultipleInstances
        	            		/home/runner/work/nitro/nitro/timeboost/auctioneer_failover_test.go:158
        	            	testing.tRunner
        	            		/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1934
        	            	runtime.goexit
        	            		/opt/hostedtoolcache/go/1.25.4/x64/src/runtime/asm_amd64.s:1693
        	Test:       	TestAuctioneerFailover_MultipleInstances
--- FAIL: TestAuctioneerFailover_MultipleInstances (16.06s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@tsahee tsahee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee enabled auto-merge November 19, 2025 15:43
@tsahee tsahee added this pull request to the merge queue Nov 19, 2025
Merged via the queue into master with commit 2739812 Nov 19, 2025
23 checks passed
@tsahee tsahee deleted the validate-non-empty-genesis branch November 19, 2025 16:16
joshuacolvin0 added a commit that referenced this pull request Dec 1, 2025
…y-genesis

Modify validateGenesisAssertion to handle non-empty genesis (#4031)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants