Skip to content

Modify validateGenesisAssertion to handle non-empty genesis (#4031)#4087

Merged
joshuacolvin0 merged 3 commits into
v3.9.x-releasefrom
backport-validate-non-empty-genesis
Dec 1, 2025
Merged

Modify validateGenesisAssertion to handle non-empty genesis (#4031)#4087
joshuacolvin0 merged 3 commits into
v3.9.x-releasefrom
backport-validate-non-empty-genesis

Conversation

@amsanghi

Copy link
Copy Markdown
Contributor

Backport of #4031

@amsanghi amsanghi changed the base branch from master to v3.9.x-release November 28, 2025 15:47
@amsanghi amsanghi marked this pull request as ready for review November 28, 2025 15:48

@joshuacolvin0 joshuacolvin0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit 88edd3a into v3.9.x-release Dec 1, 2025
16 checks passed
@joshuacolvin0 joshuacolvin0 deleted the backport-validate-non-empty-genesis branch December 1, 2025 20:44
@github-actions

github-actions Bot commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
2167 4 2163 0
View the top 3 failed tests by shortest run time
TestValidationInputsAtWithWasmTarget
Stack Traces | 2.750s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
        github.com/offchainlabs/nitro/system_tests.TestValidationInputsAtWithWasmTarget(0xc0756b0540)
        	/home/runner/work/nitro/nitro/system_tests/validation_inputs_at_test.go:70 +0x970
        testing.tRunner(0xc0756b0540, 0x3d09600)
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1997 +0x465
        
    validation_inputs_at_test.go:70: �[31;1m [] failed calculating position for validation: batch not found on L1 yet �[0;0m
�[90mTime to activate read-return-data: 317.25724ms�[0;0m
�[90mread-return-data.evm 0xA02062aa4Cb0872315ACA3eA6dBF077d90B2DAC1�[0;0m
�[34;1mchecking calls with partial return data�[0;0m
�[90mTime to activate multicall: 341.525553ms�[0;0m
�[90mmulticall: len 5.31K vs 12.50K�[0;0m
�[90mTime to activate log: 282.841618ms�[0;0m
�[90mTime to activate log: 290.26665ms�[0;0m
�[90mTime to activate storage: 289.584465ms�[0;0m
�[90mTime to activate storage: 234.524976ms�[0;0m
�[90mmulticall: len 5.31K vs 12.50K�[0;0m
�[90mmulticall: len 5.31K vs 12.50K�[0;0m
--- FAIL: TestValidationInputsAtWithWasmTarget (2.75s)
TestVersion30
Stack Traces | 10.950s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
�[90mbad-export: len 0.05K vs 0.05K�[0;0m
�[90mTime to activate bad-export: 38.741853ms�[0;0m
    precompile_inclusion_test.go:90: goroutine 455142 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.4/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40c33b0, 0xc09f29aa80}, {0x4080d20, 0xc2a4061050}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc09f29aa80, {0x4080d20, 0xc2a4061050}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1790 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc09f29aa80, 0x1e, {0xc114d01db0, 0x6, 0x48e1d4?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion30(0xc09f29aa80?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:67 +0x798
        testing.tRunner(0xc09f29aa80, 0x3d09618)
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion30 (10.95s)
TestTwoNodesLongLocalDAS
Stack Traces | 38.070s run time
=== RUN   TestTwoNodesLongLocalDAS
=== PAUSE TestTwoNodesLongLocalDAS
=== CONT  TestTwoNodesLongLocalDAS
    twonodeslong_test.go:79: DelayedFaucet has 80008000000000000800, per delayed: 100000000000000001, baseprice: 1e+08
    twonodeslong_test.go:135: Done sending 64 delayed transfers 239 direct transfers
ERROR[12-01|20:52:50.278] Dangling trie nodes after full cleanup
    twonodeslong_test.go:168: delayed balance 6400000000000000064 expected 6400000000000000064 transfers 64
    twonodeslong_test.go:169: direct balance 46600699 expected 47800717 transfers 239
    twonodeslong_test.go:172: owner balance 115792089237316195423570985008687907853269984665640564039457583999486729639927 delayed faucet 73607865600000000736
    twonodeslong_test.go:173: �[31;1m [Unexpected balance] �[0;0m
ERROR[12-01|20:52:51.727] Error getting finality msg count         scenario=safe err="io: read/write on closed pipe"
ERROR[12-01|20:52:51.732] Error getting finality msg count         scenario=safe err="io: read/write on closed pipe"
ERROR[12-01|20:52:51.737] Error getting finality msg count         scenario=safe err="io: read/write on closed pipe"
--- FAIL: TestTwoNodesLongLocalDAS (38.07s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants