Skip to content

fix stopping block meta-data fetcher#4018

Merged
joshuacolvin0 merged 1 commit into
masterfrom
stop-block-metadata-fetcher
Nov 14, 2025
Merged

fix stopping block meta-data fetcher#4018
joshuacolvin0 merged 1 commit into
masterfrom
stop-block-metadata-fetcher

Conversation

@magicxyyz

Copy link
Copy Markdown
Contributor

Fixes NIT-4121

@magicxyyz magicxyyz requested review from Tristan-Wilson, diegoximenes and ganeshvanahalli and removed request for diegoximenes November 14, 2025 22:03
@github-actions

Copy link
Copy Markdown
Contributor

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
2160 3 2157 0
View the top 3 failed tests by shortest run time
TestValidationInputsAtWithWasmTarget
Stack Traces | 2.940s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
        github.com/offchainlabs/nitro/system_tests.Require(0xc095e5b6c0, {0x409b900, 0xc096342480}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1759 +0x5d
        github.com/offchainlabs/nitro/system_tests.TestValidationInputsAtWithWasmTarget(0xc095e5b6c0)
        	/home/runner/work/nitro/nitro/system_tests/validation_inputs_at_test.go:70 +0x970
        testing.tRunner(0xc095e5b6c0, 0x3d22ca0)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    validation_inputs_at_test.go:70: �[31;1m [] failed calculating position for validation: batch not found on L1 yet �[0;0m
�[90mTime to activate multicall: 209.990623ms�[0;0m
�[90mEmitting 0 topics�[0;0m
�[90mEmitting 1 topics�[0;0m
�[90mEmitting 2 topics�[0;0m
�[90mTime to activate create: 303.593654ms�[0;0m
�[90mEmitting 3 topics�[0;0m
�[90mEmitting 4 topics�[0;0m
�[90mstorage: len 5.46K vs 13.85K�[0;0m
�[34;1mdeployed keccak to 0x1e62725BdC6292d1F6fB4984Da3d5525e91C0636�[0;0m
--- FAIL: TestValidationInputsAtWithWasmTarget (2.94s)
TestVersion40
Stack Traces | 5.970s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
ERROR[11-14|22:01:14.362] a large batch posting backlog exists     recentlyHitL1Bounds=false currentPosition=85 messageCount=167 messagesPerBatch=1 postedMessages=1 unpostedMessages=82 batchBacklogEstimate=82
ERROR[11-14|22:01:14.364] Dangling trie nodes after full cleanup
    precompile_inclusion_test.go:90: goroutine 455257 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40de510, 0xc043b97a40}, {0x409bd80, 0xc09f18df20}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc043b97a40, {0x409bd80, 0xc09f18df20}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1759 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc043b97a40, 0x28, {0xc07faafdf8, 0x5, 0x39?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion40(0xc043b97a40?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:71 +0x64b
        testing.tRunner(0xc043b97a40, 0x3d22cc0)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion40 (5.97s)
TestEthSyncing
Stack Traces | 25.280s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [11-14|21:55:28.718] Loaded most recent local block           number=0   hash=5bd1cc..58f1c8                   age=56y8mo6d
INFO [11-14|21:55:28.718] Starting work on payload                 id=0x032f474958112955
TRACE[11-14|21:55:28.718] Engine API request received              method=GetPayload                    id=0x032f474958112955
WARN [11-14|21:55:28.718] Failed to load snapshot                  err="missing or corrupted snapshot"
DEBUG[11-14|21:55:28.718] Executing EVM call finished              runtime="565.42µs"
DEBUG[11-14|21:55:28.718] Served eth_call                          reqid=31   duration="772.348µs"
TRACE[11-14|21:55:28.719] Handled RPC response                     reqid=31   duration="1.793µs"
INFO [11-14|21:55:28.718] Rebuilding state snapshot
DEBUG[11-14|21:55:28.719] Journalled generator progress            progress=empty
INFO [11-14|21:55:28.719] State snapshot generator is not found
INFO [11-14|21:55:28.719] Starting snapshot generation             root=56e81f..63b421 accounts=0  slots=0     storage=0.00B   dangling=0 elapsed="3.196µs"
INFO [11-14|21:55:28.719] Initialized path database                triecache=154.00MiB statecache=102.00MiB buffer=256.00MiB state-history="last 90000 blocks"
DEBUG[11-14|21:55:28.719] Start snapshot generation                root=392091..89adff
INFO [11-14|21:55:28.719] Resuming snapshot generation             root=56e81f..63b421 accounts=0  slots=0     storage=0.00B   dangling=0 elapsed="105.187µs"
DEBUG[11-14|21:55:28.719] Journalled generator progress            progress=empty
DEBUG[11-14|21:55:28.719] Served eth_unsubscribe                   reqid=32   duration="14.487µs"
INFO [11-14|21:55:28.719] Resuming state snapshot generation       root=392091..89adff accounts=0  slots=0     storage=0.00B   dangling=0 elapsed="545.263µs"
TRACE[11-14|21:55:28.719] Proved state range                       kind=account prefix=0x61 last=0x
INFO [11-14|21:55:28.719] Writing custom genesis block
--- FAIL: TestEthSyncing (25.28s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@magicxyyz magicxyyz marked this pull request as ready for review November 14, 2025 23:20

@joshuacolvin0 joshuacolvin0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 added this pull request to the merge queue Nov 14, 2025
Merged via the queue into master with commit 3b60442 Nov 14, 2025
25 checks passed
@joshuacolvin0 joshuacolvin0 deleted the stop-block-metadata-fetcher branch November 14, 2025 23:50
joshuacolvin0 added a commit that referenced this pull request Nov 25, 2025
stop block metdata fetcher when node stops (#4018)
0x19 pushed a commit to Tenderly/net-nitro that referenced this pull request Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants