Skip to content

stop block metdata fetcher when node stops (#4018)#4021

Merged
joshuacolvin0 merged 1 commit into
v3.9.x-releasefrom
stop-fetcher
Nov 25, 2025
Merged

stop block metdata fetcher when node stops (#4018)#4021
joshuacolvin0 merged 1 commit into
v3.9.x-releasefrom
stop-fetcher

Conversation

@joshuacolvin0

Copy link
Copy Markdown
Member

backports #4018

@tsahee tsahee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
2165 3 2162 0
View the top 3 failed tests by shortest run time
TestVersion30
Stack Traces | 6.250s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [11-15|00:14:22.956] HTTP server stopped                      endpoint=127.0.0.1:39701
TRACE[11-15|00:14:22.956] P2P networking is spinning down
    precompile_inclusion_test.go:90: goroutine 455187 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40c3370, 0xc0ad031340}, {0x4080ce0, 0xc24d2ce300}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc0ad031340, {0x4080ce0, 0xc24d2ce300}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1759 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc0ad031340, 0x1e, {0xc0afacbdb0, 0x6, 0x0?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion30(0xc0ad031340?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:67 +0x798
        testing.tRunner(0xc0ad031340, 0x3d09578)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion30 (6.25s)
TestTimeboostTxsTimeoutByBlock
Stack Traces | 30.780s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
DEBUG[11-15|00:10:54.375] checkResponses                           responded=0 errored=0 checked=2
TRACE[11-15|00:10:54.379] Refreshing our lock                      id=auctioneer-4b64ae72-1763165424301003482
DEBUG[11-15|00:10:54.384] redis producer: check responses starting
DEBUG[11-15|00:10:54.384] checkResponses                           responded=0 errored=0 checked=2
DEBUG[11-15|00:10:54.392] redis producer: check responses starting
DEBUG[11-15|00:10:54.392] trimming                                 xTrimMinID=1763165448060-0 trimmed=0 trim-err=<nil>
DEBUG[11-15|00:10:54.392] checkResponses                           responded=0 errored=0 checked=2
TRACE[11-15|00:10:54.393] P2P networking is spinning down
ERROR[11-15|00:10:54.394] Context closed, autonomous auctioneer shutting down
DEBUG[11-15|00:10:54.394] consumer: setting result                 cid=2aca48ef-e7fa-47ec-b3d7-15ecee1f23b4 msgIdInStream=1763165448060-0 resultKeyInRedis=result-key:validated_bids.1763165448060-0
WARN [11-15|00:10:54.394] Error marking bid message as consumed by auctioneer msgID=1763165448060-0 error="setting result for message with message-id in stream: 1763165448060-0, error: context canceled"
DEBUG[11-15|00:10:54.394] consumer: setting result                 cid=2aca48ef-e7fa-47ec-b3d7-15ecee1f23b4 msgIdInStream=1763165448068-0 resultKeyInRedis=result-key:validated_bids.1763165448068-0
WARN [11-15|00:10:54.394] Error marking bid message as consumed by auctioneer msgID=1763165448068-0 error="setting result for message with message-id in stream: 1763165448068-0, error: context canceled"
INFO [11-15|00:10:54.394] Acknowledged bids in redis stream        count=2
ERROR[11-15|00:10:54.394] Could not resolve auction for round      error="error waiting for transaction to be mined: context canceled"
ERROR[11-15|00:10:54.394] Context closed, autonomous auctioneer shutting down
INFO [11-15|00:10:54.394] Context done while waiting redis streams to be ready, failed to start
INFO [11-15|00:10:54.394] Context done while claiming message to indicate heartbeat messageID=1763165448060-0 error="context canceled"
INFO [11-15|00:10:54.394] Context done while claiming message to indicate heartbeat messageID=1763165448068-0 error="context canceled"
--- FAIL: TestTimeboostTxsTimeoutByBlock (30.78s)
TestOutOfGasInStorageCacheFlush
Stack Traces | 32.500s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
TRACE[11-15|00:14:09.240] P2P networking is spinning down
    program_test.go:2813: goroutine 676121 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40c3370, 0xc0966e8380}, {0x4080860, 0xc25bdcecc0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc0966e8380, {0x4080860, 0xc25bdcecc0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1759 +0x5d
        github.com/offchainlabs/nitro/system_tests.TestOutOfGasInStorageCacheFlush(0xc0966e8380)
        	/home/runner/work/nitro/nitro/system_tests/program_test.go:2813 +0xfe6
        testing.tRunner(0xc0966e8380, 0x3d090a0)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    program_test.go:2813: �[31;1m [] failed calculating position for validation: batch not found on L1 yet �[0;0m
ERROR[11-15|00:14:41.242] Dangling trie nodes after full cleanup
INFO [11-15|00:14:41.250] HTTP server stopped                      endpoint=127.0.0.1:34623
TRACE[11-15|00:14:41.250] P2P networking is spinning down
--- FAIL: TestOutOfGasInStorageCacheFlush (32.50s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@joshuacolvin0 joshuacolvin0 merged commit 2f24a03 into v3.9.x-release Nov 25, 2025
18 checks passed
@joshuacolvin0 joshuacolvin0 deleted the stop-fetcher branch November 25, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants