Skip to content

fix: recreate-missing-state-from panic#3464

Merged
tsahee merged 4 commits into
OffchainLabs:masterfrom
SyndicateProtocol:stylus_crash
Sep 15, 2025
Merged

fix: recreate-missing-state-from panic#3464
tsahee merged 4 commits into
OffchainLabs:masterfrom
SyndicateProtocol:stylus_crash

Conversation

@tsite

@tsite tsite commented Aug 10, 2025

Copy link
Copy Markdown
Contributor

recreate-missing-state-from panics when attempting to execute stylus code as the stylus target cache is uninitialized

recreate-missing-state-from panics when attempting to execute stylus code
as the stylus target cache is uninitialized
@eljobe eljobe requested a review from tsahee August 11, 2025 09:42
tsite added a commit to SyndicateProtocol/syndicate-appchains that referenced this pull request Aug 11, 2025
Ticket
Related Linear Ticket: SEQ-1235
What does this PR do?
Summary:
add an in-memory db for storing natively compiled wasm stylus programs while building blocks (first commit)
Key Changes:
also refactor synd-enclave to increase readability (remaining commits)
Breaking changes?
Yes/No:
No
Metrics changes?
Yes/No:
No
Anything interesting?
I found a bug with the recreate-missing-state flag: fix: recreate-missing-state-from panic OffchainLabs/nitro#3464
running nitro nodes in archive mode is essential, otherwise if the start block for the proof is too old and the state trie has been pruned, the node needs to re-execute all blocks from the genesis block onwards to derive it which can be slow.
How can this PR be tested?
./tee-verifier --start-batch 1030 --end-batch 1040 on manchego no longer fails
Comment thread cmd/nitro/init.go Outdated
@tsite tsite requested a review from tsahee August 26, 2025 01:09

@tsahee tsahee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented Aug 27, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 22.68%. Comparing base (39c4895) to head (8fd94c8).
⚠️ Report is 247 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3464       +/-   ##
===========================================
+ Coverage    0.00%   22.68%   +22.68%     
===========================================
  Files           8      387      +379     
  Lines         363    58652    +58289     
===========================================
+ Hits            0    13305    +13305     
- Misses        363    43305    +42942     
- Partials        0     2042     +2042     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsahee

tsahee commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

@tsite this PR seems good but I cannot merge it beccause it isn't up-to-base-branch.
Our base branch is, of course, constantly changing. Please give me permission to push to the branches in your repository, and then I'll be able to update this branch and immediately merge the PR.

Thank you!

@tsite

tsite commented Sep 12, 2025

Copy link
Copy Markdown
Contributor Author

@tsahee I sent you an invite to the repo & also updated the base branch

@tsahee

tsahee commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

@tsite Thanks! I think you invited me to your go-ethereum fork instead of the nitro one :)

@tsahee tsahee enabled auto-merge September 15, 2025 22:58
@tsahee tsahee merged commit ac3112a into OffchainLabs:master Sep 15, 2025
18 checks passed
tsite pushed a commit to SyndicateProtocol/nitro that referenced this pull request Oct 31, 2025
tsite pushed a commit to SyndicateProtocol/nitro that referenced this pull request Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants