synd-enclave: fix stylus bug#712
Conversation
move wavm structures to wavmio & split into files to increase readability
| // TODO: make sure spurious errors eg out of memory are not returned by the zlib reader and rlp decoder | ||
| // These functions should panic if the compressed data is valid but decoding fails |
There was a problem hiding this comment.
lingering TODO
can we just panic if rlp.DecodeBytes return an error?
There was a problem hiding this comment.
that would be nice, but unfortunately invalid compressed data is valid (since the sequencing contract does not validate it) and needs to be ignored instead triggering a panick
There was a problem hiding this comment.
yeah I found that odd, just going off the text in the comment 😄
should panic if the compressed data is valid but decoding fails
There was a problem hiding this comment.
ah the comment is a bit confusing, it's referring to spurious errors - library code such as rlp.DecodeBytes or zlib.NewReader should never return an error if the compressed data if valid but the machine runs out of resources, it should panic instead
Ticket
What does this PR do?
Breaking changes?
Metrics changes?
Anything interesting?
How can this PR be tested?