Skip to content

SPIFFS: updated for recent vfs.h changes#1

Closed
jnohlgard wants to merge 51 commits intoOTAkeys:pr/spiffsfrom
jnohlgard:spr/spiffs-vfs_mount
Closed

SPIFFS: updated for recent vfs.h changes#1
jnohlgard wants to merge 51 commits intoOTAkeys:pr/spiffsfrom
jnohlgard:spr/spiffs-vfs_mount

Conversation

@jnohlgard
Copy link
Copy Markdown

These are the updates required to get SPIFFS running on the current state of RIOT-OS#5616

(rebase on RIOT-OS#5616 after merging)

Joakim Nohlgård and others added 30 commits July 13, 2016 16:44
Some USEMODULE parts (e.g. defined in ${BOARD}/Makefile.dep) were not
being properly exported to CFLAGS -DMODULE_xxx options.
The VFS layer provides file system abstractions to allow using a unified
interface to access files from mounted file systems.
usage: vfs r /path/to/file nbytes offset

Only reading is currently supported

#define ENABLE_DEBUG (0)
#include <debug.h>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to find a better solution, but if not defined here, we cannot use the SPIFFS_DBG* macros.
But it sucks...

@vincent-d
Copy link
Copy Markdown
Member

@gebart Thanks !
Unfortunately I modified the branch in the mean time.
But I'll fix the conflict and merge that asap.

@vincent-d
Copy link
Copy Markdown
Member

merged, thanks !

@vincent-d vincent-d closed this Jul 14, 2016
@jnohlgard jnohlgard deleted the spr/spiffs-vfs_mount branch July 26, 2016 16:42
vincent-d pushed a commit that referenced this pull request Dec 20, 2018
* drivers/ccs811: fix types in debug messages

* drivers/driver_ccs811_full: fix unused variable build error
toonst pushed a commit that referenced this pull request Jul 19, 2019
The evtimer_msg test is expanded to also delete entries.

Furthermore the messages that are printed should now show
numbers that are very close (if not equal). Something like
this:
At    740 ms received msg 0: "#2 supposed to be 740"
At   1081 ms received msg 1: "#0 supposed to be 1081"
At   1581 ms received msg 2: "#1 supposed to be 1581"
At   4035 ms received msg 3: "#3 supposed to be 4035"

The function evtimer_print is also called to show the
intermediate status of evtimer entries.
vincent-d pushed a commit that referenced this pull request Sep 6, 2019
The test randomly fails on `native` due to timers being not accurate but
it cannot be otherwise. So better disable it than raising fake errors.

    main(): This is RIOT! (Version: buildtest)
    Testing generic evtimer
    This should list 2 items
    ev #1 offset=1000
    ev #2 offset=500
    This should list 4 items
    ev #1 offset=659
    ev #2 offset=341
    ev #3 offset=500
    ev #4 offset=2454
    Are the reception times of all 4 msgs close to the supposed values?
    At    662 ms received msg 0: "#2 supposed to be 659"
    At   1009 ms received msg 1: "#0 supposed to be 1000"
    At   1511 ms received msg 2: "#1 supposed to be 1500"

    Traceback (most recent call last):
      File "/tmp/dwq.0.3125418833043728/ef3af88c4b3615788b164464a437df5c/tests/evtimer_msg/tests/01-run.py", line 33, in <module>
        sys.exit(run(testfunc))
      File "/tmp/dwq.0.3125418833043728/ef3af88c4b3615788b164464a437df5c/dist/pythonlibs/testrunner/__init__.py", line 29, in run
        testfunc(child)
      File "/tmp/dwq.0.3125418833043728/ef3af88c4b3615788b164464a437df5c/tests/evtimer_msg/tests/01-run.py", line 26, in testfunc
        assert(actual in range(expected - ACCEPTED_ERROR, expected + ACCEPTED_ERROR))
    AssertionError
vincent-d pushed a commit that referenced this pull request May 6, 2020
The ROM size is encoded in the part number of the Atmel SAM chips.
RAM size is not encoded directly, so get it by parsing the chip's vendor file.

The file remains in the page cache for the compiler to use, so the overhead
should be minimal:

on master:

  Benchmark #1: make BOARD=samr21-xpro -j
    Time (mean ± σ):     527.9 ms ±   4.9 ms    [User: 503.1 ms, System: 69.6 ms]
    Range (min … max):   519.7 ms … 537.2 ms    10 runs

with this patch:

  Benchmark #1: make BOARD=samr21-xpro -j
    Time (mean ± σ):     535.6 ms ±   4.0 ms    [User: 507.6 ms, System: 75.1 ms]
    Range (min … max):   530.6 ms … 542.0 ms    10 runs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants