BadRequest exception handling was added#1894
Merged
anton-abushkevich merged 2 commits intomasterfrom Jun 15, 2021
Merged
Conversation
Some translations were changed(#1892)
chrisknoll
reviewed
Jun 10, 2021
| "numberOfPatients": "* 환자 수", | ||
| "numberOfPatientsPlaceholder": "숫자 입력", | ||
| "numberOfPatientsEmpty": "환자 수는 양의 정수여야 합니다", | ||
| "numberOfPatientsEmpty": "Number of patients must be a positive integer between 1 and 500", |
Collaborator
There was a problem hiding this comment.
Do we need a korean translation here?
Contributor
Author
There was a problem hiding this comment.
Yes, we need translations, but I can't get them now. Besides there're some other untranslated constants
| "numberOfPatients": "*患者数量", | ||
| "numberOfPatientsPlaceholder": "输入一个数字", | ||
| "numberOfPatientsEmpty": "患者数量必须正整数", | ||
| "numberOfPatientsEmpty": "Number of patients must be a positive integer between 1 and 500", |
Collaborator
There was a problem hiding this comment.
Same here, should this be translated?
Contributor
Author
There was a problem hiding this comment.
Yes, we need translations, but I can't get them now. Besides there're some other untranslated constants
| @@ -2621,7 +2621,7 @@ | |||
| "sampleNameEmpty": "Sample name cannot be empty", | |||
| "numberOfPatients": "* Number of patients", | |||
Contributor
There was a problem hiding this comment.
Let's add text "(from 1 to 500)" to numberOfPatients. To all translations.
chrisknoll
approved these changes
Jun 14, 2021
Collaborator
chrisknoll
left a comment
There was a problem hiding this comment.
Thanks for the information. This looks good to me, but defer to any other concerns that others raise.
ssuvorov-fls
added a commit
that referenced
this pull request
Jun 15, 2021
m0nhawk
pushed a commit
to uc-cdis/WebAPI
that referenced
this pull request
Nov 1, 2021
* BadRequest exception handling was added Some translations were changed(OHDSI#1892) * Some translations were changed(OHDSI#1890) Co-authored-by: Sergey Suvorov <sergey.suvorov@odysseusinc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some translations were changed
fixes #1890