AOT Compatible: Add overrideVersion to enforce -Version precedence#7133
Merged
Nigusu-Allehu merged 5 commits intodevfrom Feb 17, 2026
Merged
AOT Compatible: Add overrideVersion to enforce -Version precedence#7133Nigusu-Allehu merged 5 commits intodevfrom
Nigusu-Allehu merged 5 commits intodevfrom
Conversation
agocke
reviewed
Feb 13, 2026
zivkan
approved these changes
Feb 16, 2026
nkolev92
approved these changes
Feb 17, 2026
Member
nkolev92
left a comment
There was a problem hiding this comment.
I was hoping there'd be a way to minimize this pattern of overriding, but the PackageBuilder is the first place we read the nuspec, so unfortunately seems like a much bigger refactoring to get rid of this pattenrn.
Nigusu-Allehu
added a commit
that referenced
this pull request
Feb 18, 2026
Nigusu-Allehu
added a commit
that referenced
this pull request
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes:
related: NuGet/Home#14408
Description
packallows setting the package version via:-Properties version=<v>-Version <v>-Versionshould have the highest priority. Previously, this precedence was enforced using reflection to inspectPackArgs.VersioninsideManifest.ReadFrom.This PR ensures the override is done by directly passing the -Version value down to Manifest,
Previous implementation PR: #6092 , #6361
PR Checklist