[Pack] Fix version override on nuspec when using token replacement#6361
Merged
[Pack] Fix version override on nuspec when using token replacement#6361
Conversation
nkolev92
previously approved these changes
Mar 31, 2025
Contributor
Author
|
@nkolev92 fixed the test |
aortiz-msft
approved these changes
Mar 31, 2025
nkolev92
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14219
Description
This a regression introduced by #6092, [PackArgs stores the version specified in CLI in the
Propertiesvariable] (https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Core/NuGet.Commands/CommandRunners/PackCommandRunner.cs#L700-L706), but customers can also add their custom Properties as an argument.This
Propertiesare then handled by a token replacement when parsing the nuspec https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Core/NuGet.Packaging/PackageCreation/Authoring/Manifest.cs#L125.The if I added was looking at the
Propertiesvariable fromPackArgsinstead of theVersionproperty, this caused a version override with just the Version property.PR Checklist
[ ] Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.