Skip to content

Ensure IsVsOfflineFeed is calculated correctly on 64-bit machines#4817

Merged
nkolev92 merged 1 commit intodevfrom
dev-nkolev92-fixtelemetryutility
Sep 26, 2022
Merged

Ensure IsVsOfflineFeed is calculated correctly on 64-bit machines#4817
nkolev92 merged 1 commit intodevfrom
dev-nkolev92-fixtelemetryutility

Conversation

@nkolev92
Copy link
Member

Bug

Fixes: NuGet/Home#12110
Fixes: NuGet/Home#10926

Regression? Last working version:
Yes, 5.11, before VS became 64-bit.

Description

Getting the program files path will vary based on the process bitness, https://learn.microsoft.com/en-us/dotnet/api/system.environment.specialfolder?view=net-6.0#fields.

We explicitly check both paths.

I have also uncommented a few tests that aren't broken anymore.

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@nkolev92 nkolev92 requested a review from a team as a code owner September 24, 2022 02:36
@nkolev92
Copy link
Member Author

Given that this is a regression and we're having CI problems I'll be force merging this

@nkolev92 nkolev92 merged commit 0c551dc into dev Sep 26, 2022
@nkolev92 nkolev92 deleted the dev-nkolev92-fixtelemetryutility branch September 26, 2022 19:22
AdmiringWorm added a commit to chocolatey/NuGet.Client that referenced this pull request Dec 19, 2022
Insert 6.4.0-rc.123 into rel/d17.4 on 11/07/2022 23:47:12

* tag '6.4.0.123': (60 commits)
  fix a logic error that caused AbandonedMutexException while executing migrations (release-6.4.x) (NuGet#4895)
  unblock source build failing due to fatal: transport 'file' not allowed error (NuGet#4867) (NuGet#4874)
  Signing:  update to August 2022 CTL (NuGet#4791) (NuGet#4850)
  Merged PR 422933: Prefer BCL Directory create API over helper class (7.0.1xx-rc2)
  Fix empty combobox when package is not present in project file (NuGet#4844) (NuGet#4848)
  Fix component detection alert for microsoft.owin package (NuGet#4841) (NuGet#4845)
  Make release label RC, move to escrow mode
  Adds special case to include transitive origins in GetInstalledAndTransitivePackagesAsync API (NuGet#4824)
  Add longPathAware manifest to NuGet.Build.Tasks.Console (NuGet#4830)
  VsPackageInstallerServices should not post ProjectNotNominatedException faults (NuGet#4814)
  Skip test GetOrCreateAsync_WithUnhandledExceptionInPlugin_Throws (NuGet#4831)
  Improve OptProf pipeline job run names (NuGet#4825)
  Increase HttpClientHandler.MaxConnectionsPerServer to 64 to improve PM UI performance in Visual Studio (NuGet#4798)
  Suppress CA2213 warnings to unblock dev branch (NuGet#4823)
  Ensure IsVsOfflineFeed is calculated correctly on 64-bit machines (NuGet#4817)
  Add better handling of AggregateExceptions in static graph-based restore (NuGet#4809)
  Add Component Detection task into each pipeline (NuGet#4813)
  Localizes nuget.exe with default, embedded resource assembly lookup (NuGet#4773)
  Removes BrowseObjectBase class in NuGet Solution Explorer (NuGet#4807)
  Improve TryCreateContext  (NuGet#4762)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants