fix(setup): persist provider when switching model endpoints#951
Closed
StefanIsMe wants to merge 1 commit into
Closed
fix(setup): persist provider when switching model endpoints#951StefanIsMe wants to merge 1 commit into
StefanIsMe wants to merge 1 commit into
Conversation
1 task
teknium1
added a commit
that referenced
this pull request
Mar 14, 2026
fix(setup): salvage keep-current provider handling from #951
Contributor
|
Merged via PR #1283. Your substantive setup-side fix was cherry-picked and adapted onto current main, but we narrowed it to the keep-current/provider-selection pieces that still mattered because current main already handles most of the broader provider persistence through config-first resolution. Thanks again for the contribution. |
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…f48b210a fix(setup): salvage keep-current provider handling from NousResearch#951
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…f48b210a fix(setup): salvage keep-current provider handling from NousResearch#951
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
…f48b210a fix(setup): salvage keep-current provider handling from NousResearch#951
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…f48b210a fix(setup): salvage keep-current provider handling from NousResearch#951
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a provider-selection persistence bug in
hermes setup model.Problem:
customselected and then changed models/providers in setup, Hermes could keepHERMES_INFERENCE_PROVIDER=custom, causing runtime/provider mismatch.What this changes:
Keep currentto an explicit provider before model selection.HERMES_INFERENCE_PROVIDERin provider/model flows (including OpenAI Codex and custom endpoint flows).Why this approach:
setup modelflow) instead of requiring manual.envedits.Related Issue
N/A (no issue opened)
Fixes #
Type of Change
Changes Made
hermes_cli/setup.pyhermes_cli/main.pytests/test_setup_model_provider.pytest_setup_keep_current_custom_does_not_fall_throughtest_setup_switch_custom_to_codex_updates_providerHow to Test
HERMES_INFERENCE_PROVIDER=custom,OPENAI_BASE_URLset).hermes setup model, select Login with OpenAI Codex, choose a Codex model.HERMES_INFERENCE_PROVIDER=openai-codexOPENAI_BASE_URLis clearedChecklist
Code
fix(scope):,feat(scope):, etc.)duplicate
pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/A (N/A)cli-config.yaml.exampleif I added/changed config keys — or N/A (N/A)CONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/A (N/A)NousResearch/hermes-agent/blob/main/CONTRIBUTING.md#cross-platform-compatibility) — or N/A
Screenshots / Logs
Targeted regression tests:
pytest -q tests/test_setup_model_provider.py2 passed