fix(setup): salvage keep-current provider handling from #951#1283
Merged
Conversation
19 tasks
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…f48b210a fix(setup): salvage keep-current provider handling from NousResearch#951
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…f48b210a fix(setup): salvage keep-current provider handling from NousResearch#951
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
…f48b210a fix(setup): salvage keep-current provider handling from NousResearch#951
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…f48b210a fix(setup): salvage keep-current provider handling from NousResearch#951
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes setupno longer falls through to the generic OpenRouter/static model path when users choose Keep currentconfig.model.providerandconfig.model.base_url, not just a few env vars, so config-backed providers are handled correctlyOriginal contributor work salvaged from #951 by @StefanIsMe.
Why this salvage instead of merging #951 directly
Current main already handles most of the broader provider-persistence behavior through config-first provider resolution, so the
hermes_cli/main.pyenv-persistence changes from #951 are largely redundant now.The part that still matters is the
setup.pykeep-current normalization bug, plus some extra hardening around config-backed providers.Test plan
source /home/teknium/.hermes/hermes-agent/.venv/bin/activate && python -m pytest tests/hermes_cli/test_setup.py tests/hermes_cli/test_setup_model_provider.py -n0 -qsource /home/teknium/.hermes/hermes-agent/.venv/bin/activate && python -m pytest tests/ -n0 -q