fix(doctor): skip /models health check for MiniMax providers#947
Merged
Conversation
MiniMax APIs (global and China) don't support /v1/models, causing hermes doctor to always show HTTP 404 even with valid API keys. Skip the HTTP check for these providers and show '(key configured)' when the API key is present. Cherry-picked from PR #822 by Bartok9, rebased onto current main. Fixes #811 Co-authored-by: Bartok9 <259807879+Bartok9@users.noreply.github.com>
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…f9f7d54 fix(doctor): skip /models health check for MiniMax providers
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…f9f7d54 fix(doctor): skip /models health check for MiniMax providers
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
…f9f7d54 fix(doctor): skip /models health check for MiniMax providers
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…f9f7d54 fix(doctor): skip /models health check for MiniMax providers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picked from PR #822 by @Bartok9 (rebased onto current main — original was 197 commits behind).
Fixes #811 — MiniMax APIs (global and China) don't support
/v1/models, causinghermes doctorto always show HTTP 404 even with valid API keys.Changes
_apikey_providerstuple:supports_models_endpoint(bool)False— skips the HTTP health check✓ MiniMax (key configured)instead of⚠ MiniMax (HTTP 404)Test plan
python -m pytest tests/ -q— 3246 passed (2 pre-existing failures unrelated to this change)hermes doctor, confirm green check with '(key configured)'Co-authored-by: Bartok9 259807879+Bartok9@users.noreply.github.com