fix(doctor): skip /models health check for MiniMax providers#822
Closed
Bartok9 wants to merge 1 commit into
Closed
fix(doctor): skip /models health check for MiniMax providers#822Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
…earch#811) MiniMax APIs (both global and China) don't support the /v1/models endpoint, causing `hermes doctor` to always show HTTP 404 for these providers even when correctly configured. Changed the doctor to skip the health check for MiniMax and instead show '(key configured)' when a valid API key is present. Closes NousResearch#811
Contributor
Author
|
Note: The CI failure is unrelated to this PR. The test |
teknium1
pushed a commit
that referenced
this pull request
Mar 11, 2026
MiniMax APIs (global and China) don't support /v1/models, causing hermes doctor to always show HTTP 404 even with valid API keys. Skip the HTTP check for these providers and show '(key configured)' when the API key is present. Cherry-picked from PR #822 by Bartok9, rebased onto current main. Fixes #811 Co-authored-by: Bartok9 <259807879+Bartok9@users.noreply.github.com>
Contributor
|
Merged via PR #947. Your commit was cherry-picked with authorship preserved onto current main (original branch was 197 commits behind). Thanks for the fix and the clear root cause analysis in the issue! 🎉 |
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
MiniMax APIs (global and China) don't support /v1/models, causing hermes doctor to always show HTTP 404 even with valid API keys. Skip the HTTP check for these providers and show '(key configured)' when the API key is present. Cherry-picked from PR NousResearch#822 by Bartok9, rebased onto current main. Fixes NousResearch#811 Co-authored-by: Bartok9 <259807879+Bartok9@users.noreply.github.com>
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
MiniMax APIs (global and China) don't support /v1/models, causing hermes doctor to always show HTTP 404 even with valid API keys. Skip the HTTP check for these providers and show '(key configured)' when the API key is present. Cherry-picked from PR NousResearch#822 by Bartok9, rebased onto current main. Fixes NousResearch#811 Co-authored-by: Bartok9 <259807879+Bartok9@users.noreply.github.com>
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
MiniMax APIs (global and China) don't support /v1/models, causing hermes doctor to always show HTTP 404 even with valid API keys. Skip the HTTP check for these providers and show '(key configured)' when the API key is present. Cherry-picked from PR NousResearch#822 by Bartok9, rebased onto current main. Fixes NousResearch#811 Co-authored-by: Bartok9 <259807879+Bartok9@users.noreply.github.com>
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
MiniMax APIs (global and China) don't support /v1/models, causing hermes doctor to always show HTTP 404 even with valid API keys. Skip the HTTP check for these providers and show '(key configured)' when the API key is present. Cherry-picked from PR NousResearch#822 by Bartok9, rebased onto current main. Fixes NousResearch#811 Co-authored-by: Bartok9 <259807879+Bartok9@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #811 — MiniMax APIs (both global and China) don't support the
/v1/modelsendpoint, causinghermes doctorto always show HTTP 404 for these providers even when correctly configured.Changes
Added a fifth element to the
_apikey_providerstuple to indicate whether the provider supports the/modelshealth check endpoint. For providers that don't support it (MiniMax), we skip the HTTP check entirely and show(key configured)when a valid API key is present.Before:
After:
Rationale
The issue author did the root cause analysis: MiniMax simply doesn't support
/v1/models. Since there's no free health-check endpoint available (other endpoints consume tokens), the pragmatic fix is to show the key is configured without false-negative warnings.