Skip to content

fix: report cronjob tool as available in hermes doctor#895

Closed
stablegenius49 wants to merge 1 commit into
NousResearch:mainfrom
stablegenius49:pr-factory/issue-878-doctor-cronjob
Closed

fix: report cronjob tool as available in hermes doctor#895
stablegenius49 wants to merge 1 commit into
NousResearch:mainfrom
stablegenius49:pr-factory/issue-878-doctor-cronjob

Conversation

@stablegenius49

Copy link
Copy Markdown
Contributor

Summary

  • set HERMES_INTERACTIVE=1 when running hermes doctor so CLI-gated tool checks run in the same context as the interactive CLI
  • keep cronjob tool availability from being misreported as a missing system dependency
  • add a regression test for doctor's tool-availability path

Testing

  • pytest -q tests/hermes_cli/test_doctor.py

Fixes #878

teknium1 pushed a commit that referenced this pull request Mar 13, 2026
Set HERMES_INTERACTIVE=1 when running hermes doctor so CLI-gated
tool checks (like cronjob management) see the same context as the
interactive CLI. Uses setdefault to avoid overriding existing values.

Cherry-picked from PR #895 by stablegenius49, rebased onto current
main with conflict resolution.

Fixes #878

Co-authored-by: stablegenius49 <stablegenius49@users.noreply.github.com>
teknium1 added a commit that referenced this pull request Mar 13, 2026
Set HERMES_INTERACTIVE=1 via setdefault in run_doctor() so CLI-gated
tool checks (like cronjob) see the same context as the interactive CLI.

Cherry-picked from PR #895 by @stablegenius49.

Fixes #878

Co-authored-by: stablegenius49 <stablegenius49@users.noreply.github.com>
@teknium1

Copy link
Copy Markdown
Contributor

Merged via PR #1180! Your fix was cherry-picked with authorship preserved onto current main (PR was 233 commits behind, required conflict resolution in the test file due to new honcho tests added since).

The approach is clean — setdefault is the right call, and the test properly validates the env var is set before tool checks run. Thanks for the contribution! 🎉

@teknium1 teknium1 closed this Mar 13, 2026
angelburgosrosado pushed a commit to angelburgosrosado/hermes-agent that referenced this pull request Apr 27, 2026
Set HERMES_INTERACTIVE=1 via setdefault in run_doctor() so CLI-gated
tool checks (like cronjob) see the same context as the interactive CLI.

Cherry-picked from PR NousResearch#895 by @stablegenius49.

Fixes NousResearch#878

Co-authored-by: stablegenius49 <stablegenius49@users.noreply.github.com>
angelburgosrosado pushed a commit to angelburgosrosado/hermes-agent that referenced this pull request Apr 28, 2026
Set HERMES_INTERACTIVE=1 when running hermes doctor so CLI-gated
tool checks (like cronjob management) see the same context as the
interactive CLI. Uses setdefault to avoid overriding existing values.

Cherry-picked from PR NousResearch#895 by stablegenius49, rebased onto current
main with conflict resolution.

Fixes NousResearch#878

Co-authored-by: stablegenius49 <stablegenius49@users.noreply.github.com>
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
Set HERMES_INTERACTIVE=1 via setdefault in run_doctor() so CLI-gated
tool checks (like cronjob) see the same context as the interactive CLI.

Cherry-picked from PR NousResearch#895 by @stablegenius49.

Fixes NousResearch#878

Co-authored-by: stablegenius49 <stablegenius49@users.noreply.github.com>
olympus-terminal pushed a commit to olympus-terminal/hermes-agent that referenced this pull request May 16, 2026
Set HERMES_INTERACTIVE=1 via setdefault in run_doctor() so CLI-gated
tool checks (like cronjob) see the same context as the interactive CLI.

Cherry-picked from PR NousResearch#895 by @stablegenius49.

Fixes NousResearch#878

Co-authored-by: stablegenius49 <stablegenius49@users.noreply.github.com>
CumulusService pushed a commit to Cumulus-Service-GmbH/hermes-agent that referenced this pull request May 30, 2026
Set HERMES_INTERACTIVE=1 when running hermes doctor so CLI-gated
tool checks (like cronjob management) see the same context as the
interactive CLI. Uses setdefault to avoid overriding existing values.

Cherry-picked from PR NousResearch#895 by stablegenius49, rebased onto current
main with conflict resolution.

Fixes NousResearch#878

Co-authored-by: stablegenius49 <stablegenius49@users.noreply.github.com>
Egavasyug pushed a commit to Egavasyug/hermes-agent that referenced this pull request Jun 10, 2026
Set HERMES_INTERACTIVE=1 via setdefault in run_doctor() so CLI-gated
tool checks (like cronjob) see the same context as the interactive CLI.

Cherry-picked from PR NousResearch#895 by @stablegenius49.

Fixes NousResearch#878

Co-authored-by: stablegenius49 <stablegenius49@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: hermes doctor always reports the cronjob tool as "(system dependency not met)"

3 participants