fix: report cronjob tool as available in hermes doctor#1180
Merged
Conversation
Set HERMES_INTERACTIVE=1 when running hermes doctor so CLI-gated tool checks (like cronjob management) see the same context as the interactive CLI. Uses setdefault to avoid overriding existing values. Cherry-picked from PR #895 by stablegenius49, rebased onto current main with conflict resolution. Fixes #878 Co-authored-by: stablegenius49 <stablegenius49@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picked from PR #895 by @stablegenius49, rebased onto current main with conflict resolution (PR was 233 commits behind).
Sets
HERMES_INTERACTIVE=1viasetdefaultinrun_doctor()so CLI-gated tool checks (like cronjob management) see the same context as the interactive CLI.Why this works
The cronjob tool's
check_fnrequires one ofHERMES_INTERACTIVE,HERMES_GATEWAY_SESSION, orHERMES_EXEC_ASKto report as available. Sincehermes doctorruns from the CLI (same context ashermes), settingHERMES_INTERACTIVEis correct. Usingsetdefaultensures we don't override if already set.Testing
Fixes #878
Co-authored-by: stablegenius49 stablegenius49@users.noreply.github.com