fix(approval): load permanent command allowlist on startup#5076
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
c548400 to
187250d
Compare
Tommyeds
pushed a commit
to Tommyeds/hermes-agent
that referenced
this pull request
Apr 12, 2026
…rch#5076) Co-authored-by: Timo Karp <timo@timos-macbook-pro.taildbbd26.ts.net> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…rch#5076) Co-authored-by: Timo Karp <timo@timos-macbook-pro.taildbbd26.ts.net> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…rch#5076) Co-authored-by: Timo Karp <timo@timos-macbook-pro.taildbbd26.ts.net> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
…rch#5076) Co-authored-by: Timo Karp <timo@timos-macbook-pro.taildbbd26.ts.net>
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…rch#5076) Co-authored-by: Timo Karp <timo@timos-macbook-pro.taildbbd26.ts.net> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…rch#5076) Co-authored-by: Timo Karp <timo@timos-macbook-pro.taildbbd26.ts.net> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #4741 by @catbusconductor (cherry-picked onto current main).
Summary
load_permanent_allowlist()was fully implemented but never called — permanent approvals from/approve alwayswere written toconfig.yamlbut silently lost on restart. This adds the module-level call so they're loaded back on import.Changes
tools/approval.py: Addedload_permanent_allowlist()call at module level (+4 lines)Closes #4739, closes #4741