fix(approval): load permanent command allowlist on startup#4741
Closed
catbusconductor wants to merge 1 commit into
Closed
fix(approval): load permanent command allowlist on startup#4741catbusconductor wants to merge 1 commit into
catbusconductor wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Calls
load_permanent_allowlist()at module import time intools/approval.pyso that permanently approved command patterns persisted inconfig.yamlare actually loaded back into memory on restart.Currently,
save_permanent_allowlist()correctly writes patterns to disk when a user chooses/approve always, butload_permanent_allowlist()— though fully implemented — is never called anywhere. This means all "permanent" approvals are silently lost after every restart.Related Issue
Fixes #4739
Type of Change
Changes Made
tools/approval.py: Addedload_permanent_allowlist()call at module level (end of file) so it executes on importHow to Test
approvals.mode: manualpython3 -c "print('hello')")/approve alwayscommand_allowlistinconfig.yamlcontains the patternChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/A