fix(plugins): normalize nested bundled plugin aliases across plugin management flows#41613
Closed
mnajafian-nv wants to merge 4 commits into
Closed
Conversation
Collaborator
Signed-off-by: mnajafian-nv <mnajafian@nvidia.com>
Signed-off-by: mnajafian-nv <mnajafian@nvidia.com>
Contributor
Author
Thanks for flagging this. I agree this overlaps #41076, so I’m going to close #41613 rather than keep a competing PR open. One thing I do not believe #41076 covers is alias-normalized state mutation across the enable/disable flows. If that still matters after #41076 lands, I’m happy to address that remaining gap separately with a narrow follow-up. |
kshitijk4poor
added a commit
to kshitijk4poor/hermes-agent
that referenced
this pull request
Jun 8, 2026
…ble/disable (NousResearch#41066) Salvage consolidating three complementary community PRs into one coherent fix: - NousResearch#41076 (islam666): made `hermes plugins list` discover nested category plugins (e.g. `observability/nemo_relay`, `image_gen/openai`). - NousResearch#41613 (mnajafian-nv): the superset — nested discovery aligned with the runtime loader (reuses `PluginManager._scan_directory`/`_scan_entry_points` so list state can't drift from what actually loads), PLUS the enable/disable mutation side NousResearch#41076 left flat. - NousResearch#41081 (annguyenNous): identified the `web_server.py` dashboard plugins-hub caller of `_discover_all_plugins()`, which must also be updated for the new tuple shape + key-aware status. This combines the best of all three and fixes the mutation-side gap that made nested bundled plugins untoggleable: $ hermes plugins enable nemo_relay Plugin 'nemo_relay' is not installed or bundled. # exit 1 (before) Now `enable`/`disable`/`toggle`, the `hermes plugins list` views, the dashboard plugins-hub endpoint, and the dashboard enable/disable helpers all resolve a bare manifest name OR a full path-derived key to the canonical key the loader gates on, via a single `_resolve_plugin_reference()` normalization point, and persist that key while clearing any stale legacy bare-name alias so the two can't drift. `_plugin_status` is key+legacy-name aware. `_discover_all_plugins` now returns 6-tuples `(key, legacy_name, version, description, source, dir_path)`; ALL call sites (`cmd_list` table/plain/JSON, `_filter_plugin_entries`, `cmd_toggle`, `dashboard_remove_user_plugin`, and `web_server._merged_plugins_hub`) and the `test_plugins_cmd_list.py` fixtures are updated to match. Updating the `web_server.py` caller prevents a `ValueError: too many values to unpack` crash in the dashboard plugins-hub endpoint. Verified e2e on the real CLI + runtime loader (isolated HERMES_HOME): `hermes plugins enable nemo_relay` writes `observability/nemo_relay` to config.yaml and the loader then loads it (`enabled=True, error=None`); a stale bare-name alias is cleared on disable (no contradictory state); the dashboard `_merged_plugins_hub()` runs and lists nested plugins by canonical key. Full `tests/hermes_cli/test_plugins_cmd*` + web_server plugin tests green. Closes NousResearch#41066. Supersedes NousResearch#41076, NousResearch#41081, and NousResearch#41613. Co-authored-by: islam666 <islam666@users.noreply.github.com> Co-authored-by: mnajafian-nv <mnajafian@nvidia.com> Co-authored-by: annguyenNous <annguyenNous@users.noreply.github.com> Co-authored-by: kshitijk4poor <82637225+kshitijk4poor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix nested bundled plugin enablement state across
hermes plugins listand plugin toggle flows such asobservability/nemo_relay.The runtime loader already supports both the path-derived plugin key and the legacy bare manifest name for back-compat. The CLI plugin-management path did not fully match that behavior, so nested bundled plugins could be discovered correctly but still show stale enabled/disabled state or report a successful toggle while mixed alias entries remained behind in config.
What Changed
--enabledfiltering honor both the path-derived key and the legacy bare manifest name.enable/disablestate updates through a shared nested-plugin alias resolver so CLI mutations clean up both aliases and store one canonical key.Validation
Passed:
bash scripts/run_tests.sh tests/hermes_cli/test_plugins_cmd_list.py tests/hermes_cli/test_plugin_scanner_recursion.py -- -qResult:
33tests passed,0failedAlso ran:
scripts/run_tests.shThe repo-wide wrapper currently reports unrelated failures outside this change scope. The focused plugin-management regressions above passed for this branch.