fix: align plugins list with nested bundled plugin enablement#41595
Closed
mnajafian-nv wants to merge 3 commits into
Closed
fix: align plugins list with nested bundled plugin enablement#41595mnajafian-nv wants to merge 3 commits into
mnajafian-nv wants to merge 3 commits into
Conversation
Clear NeMo Relay plugin-config observability only after the last active Hermes session finalizes. Use the plugin's async-safe awaitable helper for both initialize and clear so session rotation remains safe under active event loops. Disable the direct ATIF fallback when plugins.toml already owns the ATIF exporter lifecycle to avoid duplicate trajectory export on finalization.
Signed-off-by: mnajafian-nv <mnajafian@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
hermes plugins listfor nested bundled plugins such asobservability/nemo_relay.The runtime loader already supports nested path-derived plugin keys and legacy bare manifest names for enablement back-compat. The CLI list path did not fully match that behavior, so a nested bundled plugin could be enabled at runtime while
hermes plugins liststill showed it asnot enabledor omitted it from--enabled.What Changed
hermes plugins listso nested bundled plugins are discovered with their path-derived keys.--enabledfiltering honor both the path-derived key and the legacy bare manifest name, consistent with runtime loader behavior.Validation
Passed:
uv run --with pytest --with pytest-timeout python -m pytest -q tests/hermes_cli/test_plugins_cmd_list.pyuv run --with pytest --with pytest-timeout python -m pytest -q tests/hermes_cli/test_plugin_scanner_recursion.py -k bundledAlso ran:
scripts/run_tests.shThe repo-wide wrapper currently reports unrelated failures outside this change scope. The focused plugin-list regressions above passed for this branch.