Skip to content

feat(desktop): stop the chat viewport from following streaming output#41414

Merged
teknium1 merged 1 commit into
mainfrom
hermes/hermes-1882e476
Jun 8, 2026
Merged

feat(desktop): stop the chat viewport from following streaming output#41414
teknium1 merged 1 commit into
mainfrom
hermes/hermes-1882e476

Conversation

@teknium1

@teknium1 teknium1 commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Summary

The desktop chat GUI no longer follows streaming output — once a turn is running, the viewport stays exactly where the user left it instead of being pinned to the bottom on every token.

Previously useThreadScrollAnchor ran a ResizeObserver that re-pinned the viewport to the bottom on every content growth while a turn streamed (plus a 1.2s post-completion bottom lock), so the window chased the text as it arrived.

Changes

  • thread-virtualizer.tsx: remove the streaming ResizeObserver re-pin loop in useThreadScrollAnchor.
  • thread-virtualizer.tsx: remove the post-run bottom lock (POST_RUN_BOTTOM_LOCK_MS).
  • Kept: the one-time jump-to-bottom on user submit / new turn / session change, so a freshly submitted message still lands in view. The user's own scroll position is then preserved through the entire stream.
  • streaming.test.tsx: reworked the two follow-asserting tests to assert no-follow; the four "stay put after scroll-up" tests already covered the disarmed path and remain green.

Validation

Before After
Tokens stream while parked at bottom viewport chases bottom viewport holds at last position
Run completes, Shiki regrows content snaps to new bottom holds at last position
New user submit jumps to bottom jumps to bottom (unchanged)
  • tsc -b -> 0 errors
  • eslint (changed files) -> 0 errors
  • vitest streaming.test.tsx -> 14/16 pass; the 2 failures (code-card rendering) are pre-existing on clean main (verified by re-running with this diff stashed) and unrelated to scroll.

Note: apps/desktop/ ships as a bundled Electron app, so this lands for users on the next desktop release, not via hermes update.

Infographic

viewport-stays-put

The desktop chat GUI pinned the viewport to the bottom on every content
growth while a turn streamed, so the window chased tokens as they arrived.
Remove that follow behavior: once a turn is running the viewport stays
exactly where the user left it.

- Delete the streaming ResizeObserver re-pin loop in useThreadScrollAnchor.
- Delete the post-run bottom lock (kept pinning ~1.2s after completion).
- Keep the one-time jump-to-bottom on user submit / new turn / session
  change so a freshly submitted message still lands in view.
- Update streaming.test.tsx to assert the viewport no longer follows
  streaming growth or snaps down on final code-highlight remeasure.
@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

🔎 Lint report: hermes/hermes-1882e476 vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 10030 on HEAD, 10030 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 5196 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@tonydwb tonydwb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Reviewed PR #41414: feat(desktop): stop the chat viewport from following streaming output

✅ Approve

  • Changes chat viewport sticky behavior, removing unwanted forced scroll.
  • Small UI-scoped diff with minimal behavioral blast radius.

Reviewed in batch on 2026-06-08

@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have labels Jun 7, 2026
@teknium1 teknium1 merged commit e029b75 into main Jun 8, 2026
20 checks passed
@teknium1 teknium1 deleted the hermes/hermes-1882e476 branch June 8, 2026 00:29
agogo233 added a commit to agogo233/hermes-agent that referenced this pull request Jun 8, 2026
* upstream/main: (430 commits)
  fix(yuanbao): bound ws.close() so an idle server can't stall shutdown ~5s (NousResearch#40607)
  docs: add Urdu translation of README (NousResearch#40578)
  fix(hindsight): send only new-turn delta on append retains instead of whole session (NousResearch#40605)
  feat(gateway): render terminal tool calls as native bash code blocks on markdown platforms (NousResearch#41215)
  feat(desktop): stop the chat viewport from following streaming output (NousResearch#41414)
  chore(release): map AlchemistChaos co-author email for NousResearch#40135 salvage
  fix(desktop): recover chat after sleep/wake by revalidating a stale remote backend
  fix(web): make _has_env config-aware so SEARXNG_URL auto-detect honors Hermes config
  fix(web): honor Hermes config-aware SEARXNG_URL lookup
  install.sh: hint at root-owned npm cache when desktop npm install fails (NousResearch#39688)
  fix(tools): percent-encode non-ascii URL components
  fix(skills): browse shows full catalog, not first 5000 (NousResearch#41413)
  feat(desktop+gateway): remote media relay — attach images/PDFs and display gateway images over the network
  feat(desktop): full tool-backend config (pickers + per-backend settings) in Settings (NousResearch#41232)
  hardening(api-server): scan cron prompts on REST create/update for parity with the agent tool
  fix: skip MCP preflight content-type probe on reconnect when already ready (NousResearch#40604)
  fix(kanban): sweep deferred scratch parent on non-scratch child completion + tests
  fix: defer scratch workspace cleanup when task has active children (NousResearch#33774)
  feat(onboarding): opt-in structured profile-build path on first contact (NousResearch#41114)
  feat(compression): temporal anchoring in compaction summaries (NousResearch#41102)
  test(discord): align clarify/model-picker tests with fail-closed component auth (NousResearch#41338)
  chore(release): map Dusk1e and LaPhilosophie for approval fail-closed salvage (NousResearch#33844, NousResearch#33866, NousResearch#30964)
  fix(discord): fail closed for component button auth when no allowlist set
  fix(feishu): fail closed for update prompt card actions
  fix(slack): re-check gateway auth on approval and slash-confirm buttons
  fix: guard int(os.getenv()) casts against malformed env vars (NousResearch#40598)
  fix: respect Honcho env var fallback in doctor and honcho status
  chore(release): add synapsesx to AUTHOR_MAP for NousResearch#40495 salvage
  fix(research): keep tool_call/tool_response pairs intact when compressing trajectories
  fix(simplex): accept display name in SIMPLEX_ALLOWED_USERS
  fix(desktop): make the running-turn timer per-session (NousResearch#41182)
  test(approval): regression for shell-escape denylist bypass (NousResearch#36846, NousResearch#36847)
  fix(security): strip shell escapes in denylist normalizer; fail-closed on missing approval module
  fix(stream+output-cap): guard empty streams and parse OpenRouter output-cap errors (NousResearch#40589)
  fix(desktop): bootstrap falls back to installed agent install.sh on GitHub 404
  feat(dashboard): change UI font from the theme picker, independent of theme (NousResearch#41145)
  fix(cli): return bool (not None) when a destructive-slash confirmation is cancelled (NousResearch#40583)
  fix(desktop): preserve configured base_url on same-provider model switch (NousResearch#41121)
  fix(desktop): stop bare-URL autolinker swallowing trailing emphasis asterisks (NousResearch#41093)
  fix(cron): bound the desktop run-history query to one job (NousResearch#41088)
  fix(desktop): scope in-session /model switch per-session, stop process-env leak (NousResearch#41120)
  chore: map bmoore210 author email for PR NousResearch#40550 salvage
  fix(desktop): scope session list to active profile + longer timeout
  fix: harden gateway startup and turn persistence
  fix(computer_use): honor custom vision routing
  fix(aux): honor model.default_headers on auxiliary client too (NousResearch#40033)
  fix(agent): honor model.default_headers for custom OpenAI-compatible providers (NousResearch#40033)
  docs(i18n): port deep-audit corrections to zh-Hans mirror (NousResearch#41104)
  fix(compression): don't overwrite the -1 post-compression sentinel in preflight seed (NousResearch#36718)
  chore(release): map singhsanidhya741@gmail.com to sanidhyasin (NousResearch#41094)
  ...
changman pushed a commit to changman/hermes-agent that referenced this pull request Jun 10, 2026
…NousResearch#41414)

The desktop chat GUI pinned the viewport to the bottom on every content
growth while a turn streamed, so the window chased tokens as they arrived.
Remove that follow behavior: once a turn is running the viewport stays
exactly where the user left it.

- Delete the streaming ResizeObserver re-pin loop in useThreadScrollAnchor.
- Delete the post-run bottom lock (kept pinning ~1.2s after completion).
- Keep the one-time jump-to-bottom on user submit / new turn / session
  change so a freshly submitted message still lands in view.
- Update streaming.test.tsx to assert the viewport no longer follows
  streaming growth or snaps down on final code-highlight remeasure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low — cosmetic, nice to have type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants