fix(dashboard): guard update endpoint in Docker with structured guidance (salvage #34831)#36263
Merged
Merged
Conversation
…nce (salvage #34831) Salvage of #34831 (@donovan-yohan), rebased onto current main with the trivial test-file merge conflict resolved (the new tests landed adjacent to other test additions in test_web_server.py; kept both). The dashboard's POST /api/hermes/update endpoint shelled out to `hermes update` unconditionally. Inside a Docker container that is an immutable image — the update can't apply, and the WebUI surfaced a raw SystemExit (#34347) while the user's real fix is `docker pull` (#35835). This guards the endpoint: when detect_install_method() reports a docker install, it records a structured 'not supported, run <command> instead' result (no subprocess spawned) and returns it to the WebUI, which renders actionable guidance instead of a crash. Co-authored-by: Donovan Yohan <34756395+donovan-yohan@users.noreply.github.com>
Contributor
🔎 Lint report:
|
This was referenced Jun 1, 2026
benbarclay
added a commit
that referenced
this pull request
Jun 2, 2026
…lure (#34347) (#37085) The dashboard Update button's backend guard (#36263) already returns a structured {ok:false, error:"docker_update_unsupported", message, update_command} envelope (HTTP 200) when running in a Docker install, instead of surfacing a raw SystemExit. But the frontend ignored that envelope: runAction() only branched on a thrown error, so the 200 fell through to the action-status poll, which reported a generic "Action failed (exit 1)" toast and never showed the actual guidance. Now runAction() inspects the update response and, on the docker_update_unsupported case, surfaces the backend's guidance message plus the recommended re-pull command directly (success-styled, since it's actionable guidance — not a crash) without starting the poll. Closes #34347.
JoeKowal
pushed a commit
to JoeKowal/hermes-agent
that referenced
this pull request
Jun 4, 2026
…nce (salvage NousResearch#34831) (NousResearch#36263) * fix: guard dashboard update in Docker * fix(dashboard): align action response type --------- Co-authored-by: Donovan Yohan <donovan-yohan@users.noreply.github.com> Co-authored-by: Donovan Yohan <34756395+donovan-yohan@users.noreply.github.com>
changman
pushed a commit
to changman/hermes-agent
that referenced
this pull request
Jun 10, 2026
…lure (NousResearch#34347) (NousResearch#37085) The dashboard Update button's backend guard (NousResearch#36263) already returns a structured {ok:false, error:"docker_update_unsupported", message, update_command} envelope (HTTP 200) when running in a Docker install, instead of surfacing a raw SystemExit. But the frontend ignored that envelope: runAction() only branched on a thrown error, so the 200 fell through to the action-status poll, which reported a generic "Action failed (exit 1)" toast and never showed the actual guidance. Now runAction() inspects the update response and, on the docker_update_unsupported case, surfaces the backend's guidance message plus the recommended re-pull command directly (success-styled, since it's actionable guidance — not a crash) without starting the poll. Closes NousResearch#34347.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvage of #34831 (@donovan-yohan) — rebased onto current main with the trivial merge conflict resolved.
The dashboard's
POST /api/hermes/updateendpoint shelled out tohermes updateunconditionally. Inside a Docker container that's an immutable image — the update can't apply, and the WebUI surfaced a rawSystemExit(#34347) while the user's real fix isdocker pull(#35835).This guards the endpoint: when
detect_install_method()reports adockerinstall, it records a structured "not supported, run<command>instead" result (no subprocess spawned) and returns it to the WebUI, which renders actionable guidance instead of crashing.Why a salvage
#34831 (donovan-yohan, the original) and #35339 (a byte-identical re-open) both conflicted against main — but only in
tests/hermes_cli/test_web_server.py, where the new tests landed adjacent to other test additions made since. The production changes (web_server.py,web/src/lib/api.ts) auto-merged cleanly. This branch rebases onto current main and resolves the test conflict by keeping both test blocks.Authorship preserved via
Co-authored-by: Donovan Yohan.Verification
tests/hermes_cli/test_web_server.pysuite passes (191 tested), including the 5 dashboard-update-guard tests.detect_install_method,format_docker_update_message,recommended_update_command_for_method) already present inhermes_cli/config.py.Closes #34831. Closes #35339.